Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump isort pre commit hook #228

Merged
merged 1 commit into from Apr 5, 2023
Merged

bump isort pre commit hook #228

merged 1 commit into from Apr 5, 2023

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Apr 5, 2023

Enforce newer isort version that fixes compatibility with a backwards incompatible change in poetry (its packager).

Only new contributors that use pre-commit appear to be affected (due to caching of old poetry versions)

@mgovers
bump isort pre commit hook
e2fb167 
Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers mgovers added the dependencies Pull requests that update a dependency file label Apr 5, 2023
@mgovers mgovers self-assigned this Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgovers mgovers removed the request for review from TonyXiang8787 April 5, 2023 07:15
@petersalemink95 petersalemink95 merged commit a62c187 into main Apr 5, 2023
18 checks passed
@petersalemink95 petersalemink95 deleted the fix/bump-isort-precommit-hook branch April 5, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersalemink95 petersalemink95 petersalemink95 approved these changes

Assignees

@mgovers mgovers

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgovers @petersalemink95