Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubeVersion math for supposedly unstable k8s releases #161

Merged
merged 1 commit into from Oct 18, 2021
Merged

Fix kubeVersion math for supposedly unstable k8s releases #161

merged 1 commit into from Oct 18, 2021

Conversation

yakkomajuri
Copy link
Contributor

See helm/helm#3810

This bit a few of our users already

@yakkomajuri yakkomajuri requested review from tiina303, fuziontech and guidoiaquinti and removed request for tiina303 October 18, 2021 11:22
@mariusandra
Copy link
Contributor

Why is nothing ever easy?

@yakkomajuri
Copy link
Contributor Author

Do our tests ever pass? 🤔
Screenshot 2021-10-18 at 11 46 22

@guidoiaquinti
Copy link
Contributor

Thanks for fixing this @yakkomajuri ! 🙌

@fuziontech fuziontech added the bump patch Updates chart version by 0.0.1 label Oct 18, 2021
fuziontech
fuziontech approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you sir.

@fuziontech fuziontech merged commit fa92c59 into main Oct 18, 2021
@fuziontech fuziontech deleted the yakkomajuri-patch-1 branch October 18, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuziontech fuziontech fuziontech approved these changes

@guidoiaquinti guidoiaquinti guidoiaquinti approved these changes

Assignees
No one assigned
Labels
bump patch Updates chart version by 0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yakkomajuri @mariusandra @guidoiaquinti @fuziontech