Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify service test pattern #4817

Merged
merged 1 commit into from Mar 3, 2020
Merged

Simplify service test pattern #4817

merged 1 commit into from Mar 3, 2020

Commits on Mar 3, 2020

  1. Simplify service test pattern

    * Make a simple test lifecycle registry, instead of creating empty
    testactivity
    
    * Remove use of `runBlockingTest`: according to
    Kotlin/kotlinx.coroutines#1222, if the test
    results in coroutines being finished on other threads, it's possible to
    receive "This job has not yet completed" exceptions, even though the
    jobs were properly terminated. Since we don't need the delay-skipping
    properties of `runBlockingTest`, I think it's OK to use `runBlocking`.
    jblebrun committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    56b5dc0 View commit details
    Browse the repository at this point in the history