Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify testpypi environment #102

Closed
wants to merge 1 commit into from

Conversation

ngoldbaum
Copy link
Collaborator

@ngoldbaum ngoldbaum commented Feb 20, 2024

No description provided.

@timkpaine
Copy link
Member

timkpaine commented Feb 20, 2024

It is not broken, it works fine. The testpypi upload part does not work though:

Notice: Attempting to perform trusted publishing exchange to retrieve a temporary short-lived API token for authentication against https://test.pypi.org/legacy due to __token__ username with no supplied password field
Error: Trusted publishing exchange failure: 
Token request failed: the server refused the request for the following reasons:

* `invalid-publisher`: valid token, but no corresponding publisher (All lookup strategies exhausted)

This generally indicates a trusted publisher configuration error, but could
also indicate an internal error on GitHub or PyPI's part.


The claims rendered below are **for debugging purposes only**. You should **not**
use them to configure a trusted publisher unless they already match your expectations.

If a claim is not present in the claim set, then it is rendered as `MISSING`.

* `sub`: `repo:Point72/csp:ref:refs/tags/v0.0.1`
* `repository`: `Point72/csp`
* `repository_owner`: `Point72`
* `repository_owner_id`: `112506536`
* `job_workflow_ref`: `Point72/csp/.github/workflows/build.yml@refs/tags/v0.0.1`
* `ref`: `refs/tags/v0.0.1`

Signed-off-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
@ngoldbaum ngoldbaum changed the title Create releases using gh CLI Specify testpypi environment Feb 20, 2024
@ngoldbaum
Copy link
Collaborator Author

I didn't see that you had pushed another tag. Glad to see the action we were using does work. I think using the gh cli is a little simpler to understand, but reverted part of this PR.

Perhaps the changes here are needed? The docs mention needing to specify an environment. You might also have to set up a deployment environment in the repo settings.

@timkpaine timkpaine added part: github_actions PRs that update GitHub Actions code tag: internal Issues and PRs for maintainance of the project - not interesting to external users part: distribution Issues and PRs related to distribution, e.g. pypa and conda labels Feb 20, 2024
@ngoldbaum
Copy link
Collaborator Author

Closing in favor of #105

@ngoldbaum ngoldbaum closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: distribution Issues and PRs related to distribution, e.g. pypa and conda part: github_actions PRs that update GitHub Actions code tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants