-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stable root cache #410
Conversation
Need to dig deeper still... The HMR fetching works on first try, but by the 2nd-3rd, it became flaky and not applying update at all despite the code payload reflecting the latest code. Need to debug the hydrated code and see what the HMR are looking at. |
side comment: would be interesting to have a graphviz view of how the bundling works. maybe a future hackathon idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a whole bunch of comments. No glaring issues. Suggested code quality improvements.
/SHIP/
Details
This PR stabilizes the root render mechanism for page runtime within the template provided by Plasmo. This will fix HMR for page runtime in general.
It also:
lightningcss
instead ofparcel/css
root
->__plasmo
.document.body
, similar to other frameworks <- this is intended for the future svelte portal.Code of Conduct