Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stable root cache #410

Merged
merged 11 commits into from
Jan 20, 2023
Merged

feat: stable root cache #410

merged 11 commits into from
Jan 20, 2023

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Jan 18, 2023

Details

This PR stabilizes the root render mechanism for page runtime within the template provided by Plasmo. This will fix HMR for page runtime in general.

It also:

Code of Conduct

@louisgv louisgv self-assigned this Jan 18, 2023
@louisgv
Copy link
Contributor Author

louisgv commented Jan 18, 2023

Need to dig deeper still... The HMR fetching works on first try, but by the 2nd-3rd, it became flaky and not applying update at all despite the code payload reflecting the latest code. Need to debug the hydrated code and see what the HMR are looking at.

@ColdSauce
Copy link
Contributor

side comment: would be interesting to have a graphviz view of how the bundling works. maybe a future hackathon idea?

Copy link
Contributor

@ColdSauce ColdSauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a whole bunch of comments. No glaring issues. Suggested code quality improvements.

/SHIP/

cli/plasmo/src/features/extra/cache-busting.ts Outdated Show resolved Hide resolved
cli/plasmo/src/features/extra/cache-busting.ts Outdated Show resolved Hide resolved
cli/plasmo/src/features/extra/cache-busting.ts Outdated Show resolved Hide resolved
cli/plasmo/src/features/extra/cache-busting.ts Outdated Show resolved Hide resolved
packages/parcel-runtime/src/runtimes/page-runtime.ts Outdated Show resolved Hide resolved
packages/parcel-runtime/src/utils/hmr-check.ts Outdated Show resolved Hide resolved
@louisgv louisgv merged commit ac5ad6e into main Jan 20, 2023
@louisgv louisgv deleted the feat-root-cache branch January 20, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Clean up cache when it gets too big
2 participants