Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict sphinx != 5.1 #1645

Merged
merged 2 commits into from Jul 25, 2022
Merged

Restrict sphinx != 5.1 #1645

merged 2 commits into from Jul 25, 2022

Conversation

rocco8773
Copy link
Member

The July 24th release of sphinx v5.1 still has a few bugs, which are causing our documentation builds to fail.

Related issues and PRs are...

This PR just nots sphinx v5.1, so hopefully we don't have to come back to update any dependencies. Assuming everything is fixed in v5.1.1.

@rocco8773 rocco8773 added no changelog entry needed docs PlasmaPy Docs at http://docs.plasmapy.org labels Jul 25, 2022
@rocco8773 rocco8773 requested a review from namurphy July 25, 2022 19:35
@rocco8773 rocco8773 marked this pull request as ready for review July 25, 2022 19:35
@github-actions github-actions bot removed the docs PlasmaPy Docs at http://docs.plasmapy.org label Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1645 (76b023f) into main (4342b08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1645   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          83       83           
  Lines        7961     7961           
=======================================
  Hits         7739     7739           
  Misses        222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4342b08...76b023f. Read the comment docs.

Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rocco8773 rocco8773 merged commit 997e329 into PlasmaPy:main Jul 25, 2022
@rocco8773 rocco8773 deleted the not_sphinx_51 branch July 25, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants