Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed decoder #4

Merged
merged 1 commit into from Mar 21, 2021
Merged

Renamed decoder #4

merged 1 commit into from Mar 21, 2021

Conversation

radarhere
Copy link

@radarhere radarhere commented Mar 21, 2021

Helps python-pillow#5242

I feel that "plain" is not sufficiently descriptive for the decoder, considering that it gets added to Image.DECODERS - so this PR renames it to "ppm_plain"

@Piolie
Copy link
Owner

Piolie commented Mar 21, 2021

That's fine by me. I went with raw and plain just because those are the terms used in the PBM/PPM specs,

@Piolie Piolie merged commit 858eb54 into Piolie:plainPPM Mar 21, 2021
@radarhere radarhere deleted the plainPPM branch March 21, 2021 04:21
radarhere pushed a commit that referenced this pull request Jun 12, 2022
* CI: Use alternatives to select python version

* CI: Specify full path to alternatives

/usr/sbin isn't in PATH

* DBG: Print uname to try to avoid bad pip install.

pip>=22 on 32-bit Cygwin seems to cause problems installing coverage.  I have no idea why this is, so I just skip upgrading pip there.

* FIX: Fix syntax of conditional for 32-bit Cygwin

I have no idea if it needs to be able to accept i386, but it will if it comes up.

* FIX: Revert earlier debug change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants