Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning to UI #1245

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Add versioning to UI #1245

wants to merge 8 commits into from

Conversation

calebeby
Copy link
Member

No description provided.

@calebeby calebeby changed the title Finish adding versioning to UI Add versioning to UI Dec 12, 2020
@varCepheid
Copy link
Collaborator

It looks like these conflicts should be easy to resolve. @calebeby Can I merge/push dev into this branch so that it doesn't keep throwing the conflict error?

@calebeby
Copy link
Member Author

Yeah, go ahead, thank you.

I'm not sure what state this PR is in, I will need to revisit it to see where I left it and if it is ready

@varCepheid
Copy link
Collaborator

Sorry to bother you, Jason, but it'll help to see if the changes appear. I don't know what I'm looking for.

@calebeby calebeby marked this pull request as draft January 29, 2022 18:05
@varCepheid varCepheid linked an issue Feb 3, 2022 that may be closed by this pull request
Add UI for versioning #907
Open
@varCepheid
Copy link
Collaborator

This appears to be doing what it's supposed to do. I don't know how I could trick it into thinking it was running a different version, so I can't test that.

@varCepheid varCepheid marked this pull request as ready for review February 3, 2022 00:52
@calebeby
Copy link
Member Author

calebeby commented Feb 3, 2022

@varCepheid I'm gonna switch this back to draft until I get a chance to review it myself (I can't request review from myself on my own PR)

@calebeby calebeby marked this pull request as draft February 3, 2022 02:52
@varCepheid varCepheid marked this pull request as ready for review February 12, 2022 00:09
@varCepheid varCepheid marked this pull request as draft February 12, 2022 00:10
@varCepheid varCepheid added wip enhancement Adds a new feature or meets a request. labels May 9, 2022
@varCepheid varCepheid added not-needed This doesn't need work right now. and removed not-needed This doesn't need work right now. labels May 29, 2022
@varCepheid varCepheid removed the wip label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jun0Tran Jun0Tran Awaiting requested review from Jun0Tran

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Adds a new feature or meets a request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UI for versioning
2 participants
@calebeby @varCepheid