Add a tests for Dagger Component.Builders and `Subcomponent.Builder…

…`s to `CanIgnoreReturnValueSuggesterTest`. #checkreturnvalue PiperOrigin-RevId: 595426409
PicnicSupermarket · Jan 3, 2024 · 4ef5e53 · 4ef5e53
1 parent 2bd7859
commit 4ef5e53
Showing 1 changed file with 54 additions and 0 deletions.
diff --git a/...com/google/errorprone/bugpatterns/checkreturnvalue/CanIgnoreReturnValueSuggesterTest.java b/...com/google/errorprone/bugpatterns/checkreturnvalue/CanIgnoreReturnValueSuggesterTest.java
@@ -872,4 +872,58 @@ public void exemptedByCustomAnnotation() {
         .setArgs("-XepOpt:CanIgnoreReturnValue:ExemptingMethodAnnotations=example.Foo")
         .doTest();
   }
+
+  @Test
+  public void daggerComponentBuilder_b318407972() {
+    helper
+        .addInputLines(
+            "Builder.java",
+            "package com.google.frobber;",
+            "import dagger.Component;",
+            "@Component.Builder",
+            "interface Builder {",
+            "  Builder setName(String name);",
+            "  String build();",
+            "}")
+        .addOutputLines(
+            "Builder.java",
+            "package com.google.frobber;",
+            "import com.google.errorprone.annotations.CanIgnoreReturnValue;",
+            "import dagger.Component;",
+            "@Component.Builder",
+            "interface Builder {",
+            // TODO(b/318407972): we shouldn't suggest @CIRV on Dagger Component.Builder setters
+            "  @CanIgnoreReturnValue",
+            "  Builder setName(String name);",
+            "  String build();",
+            "}")
+        .doTest();
+  }
+
+  @Test
+  public void daggerSubcomponentBuilder_b318407972() {
+    helper
+        .addInputLines(
+            "Builder.java",
+            "package com.google.frobber;",
+            "import dagger.Subcomponent;",
+            "@Subcomponent.Builder",
+            "interface Builder {",
+            "  Builder setName(String name);",
+            "  String build();",
+            "}")
+        .addOutputLines(
+            "Builder.java",
+            "package com.google.frobber;",
+            "import com.google.errorprone.annotations.CanIgnoreReturnValue;",
+            "import dagger.Subcomponent;",
+            "@Subcomponent.Builder",
+            "interface Builder {",
+            // TODO(b/318407972): we shouldn't suggest @CIRV on Dagger Subcomponent.Builder setters
+            "  @CanIgnoreReturnValue",
+            "  Builder setName(String name);",
+            "  String build();",
+            "}")
+        .doTest();
+  }
 }