Feature/21/serialize all #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azriel91
force-pushed
the
feature/21/serialize-all
branch
from
20996e7
to
d0cfdac
Compare
|
Thanks for taking this!! I'll try and get it reviewed by this weekend :) |
azriel91
force-pushed
the
feature/21/serialize-all
branch
from
d0cfdac
to
dc1f127
Compare
|
Both your PR's look good. :) Thanks for proactively helping out with this!! I appreciate it a lot. I think I'll squash this then merge your second PR. Does that sound good to you? |
|
That does sound good 🙂, but before that I'd like to do a few more things:
shall do that now |
|
okay cool all done (including docs for |
|
I completed the 2nd PR because I was worried about conflicts, and I think it had all your changes. If that's correct, let's go ahead and close this PR. Otherwise let me know! |
|
Yeap it did, thank you! hi5 ✋ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21.
Added a changelog as well, since I find that useful