Add AsStaticRef trait and let derive(AsRefStr) implement AsStaticRef<str>
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I appreciate the fix 👍 I think we should keep the symmetry with Either:
I will happily make the doc changes once we get this merged 😊 |
|
Rebased (onto current master) and amended. |
lo48576
changed the title
AsStaticStr trait and let derive(AsRefStr) implement itAsStaticRef trait and let derive(AsRefStr) implement AsStaticRef<str>
`#[derive(AsRefStr)]` will implement `AsStaticRef<str>`, and it enables us to get `&'static str` by `AsStaticRef::<str>::as_static()`. This will solve Peternator7#23.
|
Merged! I'll try and get this updated on crates.io this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve #23.
I'm not sure which name should be used:
AsStaticStr::as_static_str(),AsStaticStr::as_str()(<-- current choice),AsStr::as_str().Additionaly, documentation should be updated (but I didn't)...