Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy lints and some minor nitpicks #212

Merged
merged 6 commits into from Feb 19, 2022
Merged

Clippy lints and some minor nitpicks #212

merged 6 commits into from Feb 19, 2022

Conversation

hellow554
Copy link
Contributor

This fixes some clippy lints, as well as some things I found while browsing through the code.

Feel free to comment and request any changes :)

@hellow554
Copy link
Contributor Author

hellow554 commented Feb 16, 2022 •
edited

It seems that Self::Bar has been introduced in 1.37.0. Do you think lifting the msrv is feasible? :)

@Peternator7
Copy link
Owner

Hey @hellow554, thanks for the PR! I don't increasing the MSRV to use Self is the best trade-off so I'd prefer we leave those bits as is, but everything else looks good! Thanks

@hellow554
Copy link
Contributor Author

Removed the Self:: and added a clippy.toml with an msrv of 1.32.0. Hope CI is happy now :)

@Peternator7 Peternator7 merged commit 672ac26 into Peternator7:master Feb 19, 2022
@Peternator7
Copy link
Owner

LGTM 👍 Thanks for the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peternator7 Peternator7 Peternator7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellow554 @Peternator7