minimal extraction of enum_metadata from PR #207. #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal extraction of
EnumMetadata
, which excisesOpaqueRepr
from my pr #207.It doesn't yet fix the duplicate code issue, I also think there is a function in #183 which this hadn't implemented.
I need to work on the other crate where the stuff which was excised goes however,
So If anyone wants to pick this up, by all means.
I assume what needs to be done is pull as much as we can out into
strum_macros/helpers/
and then call those from the various..._inner(..)
calls. Instead of just duplicating everything. But note that the types and constness between the inherent and trait impl may differ making it difficult to remove all duplication.Otherwise i'll try and get back to this when I can -- or we can close it and reopen at that time!