Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrectly commented deprecated attribute #178

Merged
merged 3 commits into from Oct 8, 2021

Conversation

SOF3
Copy link
Contributor

@SOF3 SOF3 commented Sep 24, 2021

No description provided.

@Peternator7
Copy link
Owner

Welp that's unfortunate, since this is just the trait and not the macro itself, could you update the the "since" to 0.22. That'll be the next version and this error would likely confuse someone if it's back-dated.

@SOF3
Copy link
Contributor Author

SOF3 commented Oct 3, 2021

Hmm? I didn't actually change any behaviour, I just fixed a possible typo. But sure, I would just copy over.

Copy link
Owner

@Peternator7 Peternator7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update; sorry if I had been confusing. I had meant that we should update the "deprecation" notice to 0.22 instead of 0.13 because it wasn't doing anything until now.

strum/src/lib.rs Outdated Show resolved Hide resolved
strum_macros/src/lib.rs Outdated Show resolved Hide resolved
@SOF3
Copy link
Contributor Author

SOF3 commented Oct 4, 2021

Resolved.

@Peternator7 Peternator7 merged commit 6119f10 into Peternator7:master Oct 8, 2021
@Peternator7
Copy link
Owner

Thanks!

@SOF3 SOF3 deleted the patch-1 branch October 8, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants