Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case-insensitive EnumString #157

Conversation

ChayimFriedman2
Copy link
Contributor

Fixes #154.

Should I bump the version? Thanks.

@Peternator7
Copy link
Owner

Peternator7 commented Apr 21, 2021

This looks great! Let me make sure I understand how this interacts with serialize. It turns each serialization to be case-insensitive? That seems reasonable to me.

Also, don't worry about the version. I'll rev it when I publish the update

@ChayimFriedman2
Copy link
Contributor Author

This looks great! Let me make sure I understand how this interacts with serialize. It turns each serialization to be case-insensitive? That seems reasonable to me.

Yes, I think I also have tests for this.

@Peternator7 Peternator7 merged commit ca60910 into Peternator7:master May 3, 2021
@Peternator7
Copy link
Owner

This looks great; thanks for the feature. I'll work on getting a new version out this week.

@ChayimFriedman2 ChayimFriedman2 deleted the EnumString-ascii_case_insensitive branch May 3, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-insensitive EnumString?
2 participants