Adding support for doc comments on EnumDiscriminants generated type…
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Could you add a test to ensure it compiles? |
|
Sounds good! I’ll add a test for the new functionality, and I’ll also add
documentation and examples (I had skipped those for now, since I wanted to
get some feedback before moving forward).
…On Tue, Nov 24, 2020 at 09:46 Peter Glotfelty ***@***.***> wrote:
Looks good! Could you add a test to ensure it compiles?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGOHP7DQOBC5DP2FZ5CJYDSRPWOTANCNFSM4UAOJ6WQ>
.
|
|
@linclelinkpart5 are you interested in finishing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes (#140).