Fixes a panic caused by unwrapping an option (#105)

* Fixes a panic caused by unwrapping an option * updating to 0.19.2 to fix regression 104
Peternator7 · Aug 6, 2020 · 3299622 · 3299622
1 parent 06bbb62
commit 3299622
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.20.0
+## 0.19.2
+
+* Fixes [#104](https://github.com/Peternator7/strum/issues/104). PR [#105](https://github.com/Peternator7/strum/issues/105)
+
+## 0.19.1
 
 * **Breaking Change**: EnumVariantNames now properly adjusts to the `to_string` and `serialize` attributes.
+* There's a regression in this release that may make strum imcompatible with other plugins if those
+  plugins use non-rust syntax in their attributes. [#104](https://github.com/Peternator7/strum/issues/104)
 
 ## 0.19.0
 

diff --git a/strum/Cargo.toml b/strum/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "strum"
-version = "0.19.1"
+version = "0.19.2"
 authors = ["Peter Glotfelty <peter.glotfelty@microsoft.com>"]
 license = "MIT"
 
@@ -14,10 +14,10 @@ repository = "https://github.com/Peternator7/strum"
 readme = "../README.md"
 
 [dependencies]
-strum_macros = { path = "../strum_macros", optional = true, version = "0.19.0" }
+strum_macros = { path = "../strum_macros", optional = true, version = "0.19.2" }
 
 [dev-dependencies]
-strum_macros = { path = "../strum_macros", version = "0.19.0" }
+strum_macros = { path = "../strum_macros", version = "0.19.2" }
 
 [badges]
 travis-ci = { repository = "Peternator7/strum" }

diff --git a/strum_macros/Cargo.toml b/strum_macros/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "strum_macros"
-version = "0.19.1"
+version = "0.19.2"
 authors = ["Peter Glotfelty <peter.glotfelty@microsoft.com>"]
 license = "MIT"
 

diff --git a/strum_macros/src/helpers/has_metadata.rs b/strum_macros/src/helpers/has_metadata.rs
@@ -11,7 +11,7 @@ fn get_metadata_inner<'a>(
     it: impl IntoIterator<Item = &'a syn::Attribute>,
 ) -> Vec<syn::Meta> {
     it.into_iter()
-        .map(|attr| attr.parse_meta().unwrap())
+        .filter_map(|attr| attr.parse_meta().ok())
         .filter_map(|meta| match meta {
             syn::Meta::List(syn::MetaList { path, nested, .. }) => {
                 if path.is_ident(ident) {