Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump isort from 4.3.21 to 5.0.3 #7485

Closed
wants to merge 3 commits into from
Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 5, 2020

Bumps isort from 4.3.21 to 5.0.3.

Release notes

Sourced from isort's releases.

5.0.3 - July 4, 2020

  • Fixed setup.py command incorrectly passing check=True as a configuration parameter (see: timothycrosley/isort#1258)
  • Fixed missing patch version
  • Fixed issue #1253: Atomic fails when passed in not readable output stream

5.0.2

Ensure completeness of black profile, adding default line_length

5.0.1

No release notes provided.

5.0.0

https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/

4.3.21-2

4.3.21 - June 25, 2019 - hot fix release

  • Fixed issue #957 - Long aliases and use_parentheses generates invalid syntax
Changelog

Sourced from isort's changelog.

5.0.3 - July 4, 2020

  • Fixed setup.py command incorrectly passing check=True as a configuration parameter (see: timothycrosley/isort#1258)
  • Fixed missing patch version
  • Fixed issue #1253: Atomic fails when passed in not readable output stream

5.0.2 - July 4, 2020

  • Ensured black profile was complete, adding missing line_length definition.

5.0.1 - July 4, 2020

  • Fixed a runtime error in a vendored dependency (toml).

5.0.0 Penny - July 4, 2020

Breaking changes:

  • isort now requires Python 3.6+ to run but continues to support formatting on ALL versions of python including Python 2 code.
  • isort deprecates official support for Python 3.4, removing modules only in this release from known_standard_library:
    • user
  • Config files are no longer composed on-top of each-other. Instead the first config file found is used.
    • Since there is no longer composition negative form settings (such as --dont-skip) are no longer required and have been removed.
  • Two-letter shortened setting names (like ac for atomic) now require two dashes to avoid ambiguity: --ac.
  • For consistency with other tools -v now is shorthand for verbose and -V is shorthand for version. See Issue: #1067.
  • length_sort_{section_name} config usage has been deprecated. Instead length_sort_sections list can be used to specify a list of sections that need to be length sorted.
  • safety_excludes and unsafe have been deprecated
  • Config now includes as default full set of safety directories defined by safety excludes.
  • --recursive option has been removed. Directories passed in are now automatically sorted recursive.
  • --apply option has been removed as it is the default behaviour.
  • isort now does nothing, beyond giving instructions and exiting status code 0, when ran with no arguments.
    • a new --interactive flag has been added to enable the old style behaviour.
  • isort now works on contiguous sections of imports, instead of one whole file at a time.
  • isort now formats all nested "as" imports in the "from" form. import x.y as a becomes from x import y as a.
  • keep_direct_and_as_imports option now defaults to True.
  • appdirs is no longer supported. Unless manually specified, config should be project config only.
  • toml is now installed as a vendorized module, meaning pyproject.toml based config is always supported.
  • Completely new Python API, old version is removed and no longer accessible.
  • New module placement logic and module fully replaces old finders. Old approach is still available via --old-finders.

Internal:

  • isort now utilizes mypy and typing to filter out typing related issues before deployment.

  • isort now utilizes black internally to ensure more consistent formatting.

  • profile support for common project types (black, django, google, etc)

  • Much much more. There is some difficulty in fully capturing the extent of changes in this release - just because of how all encompassing the release is. See: Github Issues for more.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [isort](https://github.com/timothycrosley/isort) from 4.3.21 to 5.0.3.
- [Release notes](https://github.com/timothycrosley/isort/releases)
- [Changelog](https://github.com/timothycrosley/isort/blob/develop/CHANGELOG.md)
- [Commits](PyCQA/isort@4.3.21...5.0.3)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 5, 2020
@vorpal-buildbot
Copy link
Contributor

vorpal-buildbot commented Jul 5, 2020

Changelogs

isort 5.0.3

isort 5.0.2

  • Ensured black profile was complete, adding missing line_length definition.

isort 5.0.1

  • Fixed a runtime error in a vendored dependency (toml).

isort 5.0.0

Breaking changes:

  • isort now requires Python 3.6+ to run but continues to support formatting on ALL versions of python including
    Python 2 code.
  • isort deprecates official support for Python 3.4, removing modules only in this release from known_standard_library:
    • user
  • Config files are no longer composed on-top of each-other. Instead the first config file found is used.
    • Since there is no longer composition negative form settings (such as --dont-skip or it's config file variant not_skip) are no longer required and have been removed.
  • Two-letter shortened setting names (like ac for atomic) now require two dashes to avoid ambiguity: --ac.
  • For consistency with other tools -v now is shorthand for verbose and -V is shorthand for version. See Issue: 1067.
  • length_sort_{section_name} config usage has been deprecated. Instead length_sort_sections list can be used to specify a list of sections that need to be length sorted.
  • safety_excludes and unsafe have been deprecated
  • Config now includes as default full set of safety directories defined by safety excludes.
  • --recursive option has been removed. Directories passed in are now automatically sorted recursive.
  • --apply option has been removed as it is the default behaviour.
  • isort now does nothing, beyond giving instructions and exiting status code 0, when ran with no arguments.
    • a new --interactive flag has been added to enable the old style behaviour.
  • isort now works on contiguous sections of imports, instead of one whole file at a time.
  • isort now formats all nested "as" imports in the "from" form. import x.y as a becomes from x import y as a.
  • keep_direct_and_as_imports option now defaults to True.
  • appdirs is no longer supported. Unless manually specified, config should be project config only.
  • toml is now installed as a vendorized module, meaning pyproject.toml based config is always supported.
  • Completely new Python API, old version is removed and no longer accessible.
  • New module placement logic and module fully replaces old finders. Old approach is still available via --old-finders.

Internal:

  • isort now utilizes mypy and typing to filter out typing related issues before deployment.

  • isort now utilizes black internally to ensure more consistent formatting.

  • profile support for common project types (black, django, google, etc)

  • Much much more. There is some difficulty in fully capturing the extent of changes in this release - just because of how all encompassing the release is. See: Github Issues for more.

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #7485 into master will increase coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7485      +/-   ##
==========================================
+ Coverage   45.51%   45.93%   +0.42%     
==========================================
  Files         279      279              
  Lines       14060    14186     +126     
  Branches     2122     2232     +110     
==========================================
+ Hits         6399     6516     +117     
+ Misses       7368     7354      -14     
- Partials      293      316      +23     
Impacted Files Coverage Δ
pylint_monolith/monolith_checker.py 0.00% <0.00%> (ø)
decksite/view.py 60.85% <0.00%> (ø)
maintenance/elo.py 0.00% <0.00%> (ø)
decksite/data/rule.py 23.47% <0.00%> (ø)
magic/multiverse_test.py 100.00% <0.00%> (ø)
decksite/views/person_achievements.py 35.00% <0.00%> (ø)
discordbot/bot.py 4.88% <0.00%> (+1.26%) ⬆️
magic/card.py 45.41% <0.00%> (+1.60%) ⬆️
discordbot/emoji.py 48.33% <0.00%> (+1.66%) ⬆️
decksite/__init__.py 88.13% <0.00%> (+3.82%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efe744...e00eab9. Read the comment docs.

@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Travis tests have failed

Hey @dependabot[bot],
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e1069770-c1ad-11ea-8e31-7fd6e6dac888

@silasary
Copy link
Member

silasary commented Jul 6, 2020

Ooh

Currently failed due to pylint issues.
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 6, 2020

A newer version of isort exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@silasary
Copy link
Member

silasary commented Jul 7, 2020

Blocked by pylint-dev/pylint#3725

@silasary silasary closed this Sep 21, 2020
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@silasary silasary deleted the dependabot/pip/isort-5.0.3 branch September 21, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants