Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Updater's multibot state thread safe #98

Merged
merged 9 commits into from
Sep 2, 2023

Conversation

PaulSonOfLars
Copy link
Owner

What

This PR makes it possible to add/remove bots to the Updater on the fly, rather than the previous option which only allowed for adding bots, without being able to remove them.

Impact

  • Are your changes backwards compatible? Y
  • Have you included documentation, or updated existing documentation? Y
  • Do errors and log messages provide enough context? Y

@PaulSonOfLars PaulSonOfLars force-pushed the paul/improve-multibot-management branch from 18487c9 to af736f0 Compare July 30, 2023 17:04
ext/updater.go Outdated Show resolved Hide resolved
@PaulSonOfLars PaulSonOfLars force-pushed the paul/improve-multibot-management branch 3 times, most recently from 5d89dc3 to 3ab8ea8 Compare August 23, 2023 14:26
Copy link

@rusq rusq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulSonOfLars one comment, for your consideration please

samples/echoMultiBot/main.go Outdated Show resolved Hide resolved
@PaulSonOfLars PaulSonOfLars force-pushed the paul/improve-multibot-management branch 2 times, most recently from a8f71fb to 878af0b Compare September 2, 2023 11:41
@PaulSonOfLars PaulSonOfLars merged commit eab7bce into v2 Sep 2, 2023
3 checks passed
@PaulSonOfLars PaulSonOfLars deleted the paul/improve-multibot-management branch September 2, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants