Fixing construct_aad() bug (facebook#112)

PaulGrandperrin · Jan 8, 2021 · ba53089 · ba53089
1 parent fa6752c
commit ba53089
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/envelope.rs b/src/envelope.rs
@@ -287,10 +287,11 @@ impl<D: Hash> Envelope<D> {
 // Helper functions
 
 fn construct_aad(server_s_pk: &[u8], optional_ids: &Option<(Vec<u8>, Vec<u8>)>) -> Vec<u8> {
-    optional_ids
+    let ids = optional_ids
         .iter()
-        .flat_map(|(l, r)| [serialize(server_s_pk, 2), serialize(l, 2), serialize(r, 2)].concat())
-        .collect()
+        .flat_map(|(l, r)| [serialize(l, 2), serialize(r, 2)].concat())
+        .collect();
+    [serialize(server_s_pk, 2), ids].concat()
 }
 
 pub(crate) fn mode_from_ids(optional_ids: &Option<(Vec<u8>, Vec<u8>)>) -> InnerEnvelopeMode {