Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward CancellationToken analyzer and code fixer #5923

Merged
merged 23 commits into from
May 21, 2021
Merged

Forward CancellationToken analyzer and code fixer #5923

merged 23 commits into from
May 21, 2021

Commits on May 5, 2021

  1. Add analyzer to forward context.CancellationToken to methods

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    96407d9 View commit details
    Browse the repository at this point in the history

  2. Rebase fixups & fix cancellation diagnostics

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b8d3d58 View commit details
    Browse the repository at this point in the history

  3. Fixer now supports explicit param name prefix when adding 1 parameter… 

    … to the invocation is not in the right position
    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    23d2202 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary pre-emptive token checks

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    88f8ef7 View commit details
    Browse the repository at this point in the history

  5. minor tweak

    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    33857fa View commit details
    Browse the repository at this point in the history

  6. remove SharedAttribute from analyzer because 🤷

    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    9add88f View commit details
    Browse the repository at this point in the history

  7. remove using 🤦

    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    862419e View commit details
    Browse the repository at this point in the history

  8. fixer - added comment and did minor reformatting

    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    bb7a87b View commit details
    Browse the repository at this point in the history

  9. aligned property name

    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    1639a04 View commit details
    Browse the repository at this point in the history

  10. upgrade to analyzers to Microsoft.CodeAnalysis.CSharp.Workspaces 2.10… 

    ….0 and netstandard1.3
    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    a33d9e5 View commit details
    Browse the repository at this point in the history

  11. make method static in AwaitOrCaptureTasksAnalyzer

    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    f0a0a3c View commit details
    Browse the repository at this point in the history

  12. made agreed changes to ForwardCancellationTokenAnalyzer plus some oth… 

    …er tweaks
    @adamralph
    adamralph committed May 5, 2021
    Configuration menu
    Copy the full SHA
    4b35767 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. downgrade to Microsoft.CodeAnalysis.CSharp.Workspaces 2.4.0

    @adamralph
    adamralph committed May 6, 2021
    Configuration menu
    Copy the full SHA
    1888753 View commit details
    Browse the repository at this point in the history

  2. apply patterns from Particular.CodeAnalyzers tests plus minor tweaks

    @adamralph
    adamralph committed May 6, 2021
    Configuration menu
    Copy the full SHA
    79ff5dc View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Coalesce a bunch of tests

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    de6a366 View commit details
    Browse the repository at this point in the history

  2. Analyze from the method level first

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    1d8364d View commit details
    Browse the repository at this point in the history

  3. AnalysisTarget stuff no longer necessary

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    366f3e6 View commit details
    Browse the repository at this point in the history

  4. change _All The Things!_

    @adamralph
    adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    753daa3 View commit details
    Browse the repository at this point in the history

  5. Restore a bunch of this test that was cut out

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    65bb6ad View commit details
    Browse the repository at this point in the history

  6. Random Func detail

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    ed8b5cd View commit details
    Browse the repository at this point in the history

  7. Fixer shouldn't care if it's a message handler

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    e23d105 View commit details
    Browse the repository at this point in the history

  8. Extra param, make it more interesting

    @DavidBoike @adamralph
    DavidBoike authored and adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    bfb5d17 View commit details
    Browse the repository at this point in the history

  9. add note about upgrading Microsoft.CodeAnalysis.CSharp.Workspaces

    @adamralph
    adamralph committed May 21, 2021
    Configuration menu
    Copy the full SHA
    8fbadd7 View commit details
    Browse the repository at this point in the history