Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adventure Pointers #5708

Closed
wants to merge 1 commit into from
Closed

Adventure Pointers #5708

wants to merge 1 commit into from

Conversation

kashike
Copy link
Member

@kashike kashike commented May 23, 2021 •
edited

@kashike kashike self-assigned this May 23, 2021
@kashike kashike added this to In progress in Paper Development via automation May 23, 2021
@kashike kashike added this to Todo in Adventure via automation May 23, 2021
Proximyst
Proximyst reviewed May 23, 2021
View reviewed changes
Copy link
Contributor

@Proximyst Proximyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, excited for how this'll turn out

@Proximyst Proximyst moved this from Todo to In progress in Adventure May 23, 2021
kashike
kashike commented May 31, 2021
View reviewed changes
Spigot-Server-Patches/0010-Adventure.patch
+ return java.util.Optional.of((T) this.getUniqueId());
+ } else if (pointer == net.kyori.adventure.permission.PermissionChecker.POINTER) {
+ if (this.adventure$permissions == null) {
+ // todo: allow properly returning NOT_SET?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions on how to handle this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a superperms method for isPermissionSet, you could use that?

@qixils qixils mentioned this pull request Jun 12, 2021
Closed
4 tasks
@stale
Copy link

stale bot commented Aug 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@zml2008
Copy link
Contributor

zml2008 commented Aug 20, 2021

still relevant

@stale stale bot removed the resolution: stale label Aug 20, 2021
@e-im e-im added the status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. label Aug 20, 2021
@kezz
Copy link
Contributor

kezz commented Aug 20, 2021

Should probably be updated to the new Pointers system. Also could add pointers for world/entity names/uuids. Also, teams can have names/display names as well.

@kezz kezz mentioned this pull request Aug 20, 2021
Closed
@Proximyst Proximyst closed this Aug 20, 2021
Paper Development automation moved this from In progress to Done Aug 20, 2021
@Owen1212055 Owen1212055 mentioned this pull request Jan 11, 2022
Closed
@kennytv kennytv deleted the adventure/pointer branch January 9, 2023 21:52
@Machine-Maker Machine-Maker moved this from In progress to Resolved in Adventure Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zml2008 zml2008 zml2008 left review comments

@Proximyst Proximyst Proximyst left review comments

Assignees

@kashike kashike

Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.
Projects
Paper Development
  
Done
Adventure
  
Resolved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kashike @zml2008 @kezz @Proximyst @e-im