New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use websocket branch that supports tls proxy #20

Closed

philipatl wants to merge 5 commits into master from tls-proxy

philipatl commented Nov 29, 2021 •

edited

Description

I forked the gorilla/websocket repo, and made changes to support use with an https proxy.
This PR uses that fork.

https://github.com/philipatl/websocket/tree/tls-proxy
gorilla/websocket#740

Motivation and Context

It is needed for enforcer to proxy websocket connections.
See CNS-3317

How Has This Been Tested?

Verified that enforcer correctly proxies websocket connections, using an https proxy.
Integration and functional tests of enforcer are in the works.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes if appropriate.
All new and existing tests passed.


          use websocket branch that supports tls proxy

3dd3b97

welcome-to-palo-alto-networks bot commented Nov 29, 2021

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

philipatl marked this pull request as draft

November 29, 2021 22:51

philipatl added 3 commits

November 29, 2021 18:11


          change tls proxy branch to 1.4.2

4eb5ce8


          Revert "change tls proxy branch to 1.4.2"

c7c6d57

This reverts commit 4eb5ce8.


          try different lint

0fb1935

Author

philipatl commented Nov 30, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "d36916398177e0a1e7c94fd5c8815a7d178ace45",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-boot",
    "pr-id": "108",
    "commit-sha": "d37b5e1bc0bf13c587ec82024c3f35b328f200e1",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-mgr",
    "pr-id": "133",
    "commit-sha": "c60ea9049777757fdc87b052c3f61721e012f24b",
    "pipeline": "master"
  }
]

Author

philipatl commented Nov 30, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-boot",
    "pr-id": "108",
    "commit-sha": "d37b5e1bc0bf13c587ec82024c3f35b328f200e1",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-mgr",
    "pr-id": "133",
    "commit-sha": "c60ea9049777757fdc87b052c3f61721e012f24b",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "71b23f4beb9767c696a85ef8fef7d919ccd56b9e",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  }
]

Author

philipatl commented Nov 30, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-boot",
    "pr-id": "108",
    "commit-sha": "d37b5e1bc0bf13c587ec82024c3f35b328f200e1",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-mgr",
    "pr-id": "133",
    "commit-sha": "c60ea9049777757fdc87b052c3f61721e012f24b",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "35f43ed300bc0b9c287377abf2414cb3aaf12b75",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  }
]

Author

philipatl commented Nov 30, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-boot",
    "pr-id": "108",
    "commit-sha": "d37b5e1bc0bf13c587ec82024c3f35b328f200e1",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-mgr",
    "pr-id": "133",
    "commit-sha": "c60ea9049777757fdc87b052c3f61721e012f24b",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "45226c7d1b54b837d3a754c88e5490c62ca43965",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  }
]

Author

philipatl commented Nov 30, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-boot",
    "pr-id": "108",
    "commit-sha": "d37b5e1bc0bf13c587ec82024c3f35b328f200e1",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-mgr",
    "pr-id": "133",
    "commit-sha": "c60ea9049777757fdc87b052c3f61721e012f24b",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "abb9aead8f45fd80bdba38664c1602d2e1ddade5",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  }
]

Author

philipatl commented Nov 30, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-boot",
    "pr-id": "108",
    "commit-sha": "d37b5e1bc0bf13c587ec82024c3f35b328f200e1",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "cns-agent-mgr",
    "pr-id": "133",
    "commit-sha": "c60ea9049777757fdc87b052c3f61721e012f24b",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "de966633286ca78291403815ca41b5674ced7621",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  }
]

Author

philipatl commented Dec 3, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "7a33fdbc62d1903339fae73772bffd33b8cb11bd",
    "pipeline": "master"
  }
]

Author

philipatl commented Dec 3, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "39730a37821eef9364fccd7012f325a8405d364c",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "255737bf3566a60c27af030faf14a8e88fd74a63",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "0fb193525664c2f50a36663cdb9b446d5bebfe60",
    "pipeline": "master"
  }
]

philipatl marked this pull request as ready for review

December 3, 2021 17:52

philipatl requested review from primalmotion and kevincantu

December 3, 2021 18:02


          use new changes in tls-proxy branch of websocket fork

20df727

Author

philipatl commented Dec 6, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "20df727097f48d94199a433332ea3a57f011f42a",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "daee149ec13e05029d1fa63b50802d699ffb1df3",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "7e0075ddd27f1af1ca06acf94dc62bcc5c894352",
    "pipeline": "master"
  }
]

Author

philipatl commented Dec 6, 2021

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "enforcer-proxy-server",
    "component": "enforcerd",
    "pr-id": "2625",
    "commit-sha": "ba986799be60f19d78328ed5c113fe919e5210fe",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "manipulate",
    "pr-id": "163",
    "commit-sha": "704778db3905a87268e3e630b5283755950aef49",
    "pipeline": "master"
  },
  {
    "project": "enforcer-proxy-server",
    "component": "wsc",
    "pr-id": "20",
    "commit-sha": "20df727097f48d94199a433332ea3a57f011f42a",
    "pipeline": "master"
  }
]

Contributor

primalmotion commented Dec 6, 2021

not needed

primalmotion closed this

philipatl deleted the tls-proxy branch

December 6, 2021 22:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment