Add Oauth2 TokenSource support #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PagerDuty currently uses Oauth2 tokens that need to be acquired and refreshed with some frequency. The current setup only supports static string auth tokens. While uses could do the Oauth2 handling themselves, it'd lead to a quite challenging maneuvering to re-create the PagerDuty client with the new token once the previous expires, which is unnecessary when there are official canned libraries to do that for us. Another option could almost be to just use the oauth2 created Client [1], but the way `prepRequest` works would interfere with it. Fixes PagerDuty#407 1: https://pkg.go.dev/golang.org/x/oauth2#Config.Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PagerDuty currently uses Oauth2 tokens that need to be acquired and refreshed with some frequency. The current setup only supports static string auth tokens.
While uses could do the Oauth2 handling themselves, it'd lead to a quite challenging maneuvering to re-create the PagerDuty client with the new token once the previous expires, which is unnecessary when there are official canned libraries to do that for us.
Another option could almost be to just use the oauth2 created Client [1], but the way
prepRequestworks would interfere with it.Fixes #407
1: https://pkg.go.dev/golang.org/x/oauth2#Config.Client