Add missing context.Context support and propagation #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stmcallister missed two. :) |
While looking at something I discovered that I had accidentally missed adding full `context.Context` support in two places. In particular, in `service_dependency.go` the context for `AssociateServiceDependenciesWithContext` wasn't being used. Second, I missed adding context support to `AssignTags()` completely.
theckman
force-pushed
the
missing_context
branch
from
a519480
to
ae19224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at something I discovered that I had accidentally missed adding
full
context.Contextsupport in two places. In particular, inservice_dependency.gothe context forAssociateServiceDependenciesWithContextwasn't being used. Second, I missed adding context support to
AssignTags()completely.