Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid JSON struct tag, and other linter issues #319

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix invalid JSON struct tag, and other linter issues #319

merged 1 commit into from
Apr 15, 2021

Commits on Mar 30, 2021

  1. Fix invalid JSON struct tag, and other linter issues 

    This change is a pretty noisy change in that I went through and cleaned up all
of the issues that my linters flagged. I wanted to get this done, so that we can
add them as automatic CI checks for future PRs.

In the process I did find one critical bug, where we had a malformed JSON struct
tag:

https://github.com/PagerDuty/go-pagerduty/blob/69ade4b95ef0ff1d582a7d9f226a98f9db886df1/webhook.go#L44

There are two linter issues we cannot fix until v1.5.0, because they are
breaking changes. As such, the v1.5.0 development line would be the first place
we can enforce those CI checks.

Fixes #317
    @theckman
    theckman committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    b64a98d View commit details
    Browse the repository at this point in the history