Update extension_schema.go to accept a context.Context #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
added
the
undocumented feature
theckman
commented
Feb 26, 2021
| type ListExtensionSchemaResponse struct { | ||
| APIListObject | ||
| ExtensionSchemas []ExtensionSchema `json:"extension_schemas"` | ||
| } | ||
|
|
||
| // ListExtensionSchemaOptions are the options to send with the | ||
| // ListExtensionSchema reques(s). | ||
| type ListExtensionSchemaOptions struct { | ||
| APIListObject | ||
| Query string `url:"query,omitempty"` |
There was a problem hiding this comment.
@stmcallister I don't see this field documented here. Does this look like a candidate for removal as part of 1.5, or should this remain?
There was a problem hiding this comment.
Although, now that I look more maybe it's implicitly supported so that you can get the total count as part of the paginated response?
There was a problem hiding this comment.
I've reached out to our engineering team to see if we can document the query query string parameter.
There was a problem hiding this comment.
@stmcallister since this something we can (and should) solve outside of this PR, are we good to merge this one to call the context.Context addition done?
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #267