add ListServicesPaginated to services api (and tests) #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
theckman
requested changes
Feb 20, 2021
There was a problem hiding this comment.
I think overall this is something we'd like to get merged in. There are some merge conflicts that need resolved, as well as some other non-conflicts that need updating, before we could merge this in.
Please let me know if you have any questions or comments on my feedback. Thank you for the contribution! 👍
|
Comments addressed @theckman, I used the strings.Contains() approach from above, but if theres a reason to iterate manually, I can do that too. |
theckman
requested changes
Feb 25, 2021
|
@theckman done once again. |
theckman
approved these changes
Feb 26, 2021
|
@c6h12o6 git is awful and caught a merge conflict based on another PR we merged in. I'll fix it on merge in just a moment. |
|
@c6h12o6 thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new functionality to easily leverage pagedGet() in ListServices. Does not alter any existing functionality.