service_dependency: fix (dis-)associate operations #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the (dis-)associate functions by now doing the hocus pocus with
`map[string]...`. `relationships` already exists due to the JSON tag in
the struct. Without this, the payload looks like:
```json
{"relationships": {"relationships": [...] } }
```
And PD API returns "invalid request". Tested locally that it works as
expected with these changes.
stmcallister
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the (dis-)associate functions by not doing the hocus pocus with
map[string]....relationshipsalready exists due to the JSON tag inthe struct. Without this, the payload looks like:
{"relationships": {"relationships": [...] } }And PD API returns "invalid request". Tested locally that it works as
expected with these changes.