-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple of syntax and unmarshaling fixes. closes #232 #233
Conversation
Thanks for making this change! And, sorry for the delay! Were you able to get it to work? I needed to also change the type of |
@Erog38 is this ready to go? Happy to review and look at merging if so. |
My goodness, sorry about the long MR time folks! Let me spruce up a bit in here and double check a few things. |
@theckman @stmcallister I've added the array definition to the |
adding array definition to ResponderRequest vet your code kids.
fcf6816
to
697313a
Compare
@Erog38 hey there; we're in the v1.5.0 window now so we're ready to look at getting this merged-in. I would assume what you have found overlaps with #251. Feel free to broaden this PR and we can work on getting it merged. On a tactical note, it seems like the tests aren't passing in CI right now. If this PR is the broadened version, I'm happy to take a look once the tests are green. |
@Erog38 wanted to ping again to see if you be able to get the tests green on this one. |
This MR adds a field to the webhook struct, fixes struct tag syntax, and adjusts the payload for sending responder requests to match the documentation. Closes #232