delete maybe unused code in paddle\phi\infermeta\sparse\unary.h #46844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
|
@luotao1 本PR审核后如果没什么问题就merge吧 |
|
按照我的理解，这两个函数在sparse transpose的PR中根本没用上，而且只有函数声明，没有函数体，所以删了 |
|
LGTM |
luotao1
approved these changes
Oct 17, 2022
zhwesky2010
pushed a commit
to zhwesky2010/Paddle
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
delete maybe unused code in paddle\phi\infermeta\sparse\unary.h
This PR originates from https://github.com/PaddlePaddle/Paddle/pull/45849/files#r991025610