Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 3 No.23】为 Paddle 新增 paddle.incubate.sparse.is_same_shape 稀疏 API #45086

Merged
merged 6 commits into from Sep 9, 2022
Merged

【PaddlePaddle Hackathon 3 No.23】为 Paddle 新增 paddle.incubate.sparse.is_same_shape 稀疏 API #45086

merged 6 commits into from Sep 9, 2022

Conversation

gsq7474741
Copy link
Contributor

@gsq7474741 gsq7474741 commented Aug 11, 2022 •
edited

@paddle-bot
Copy link

paddle-bot bot commented Aug 11, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 11, 2022
@gsq7474741 gsq7474741 mentioned this pull request Aug 11, 2022
Closed
@gsq7474741
Copy link
Contributor Author

@zhouwei25 ci 里无关的测试挂了一堆，麻烦帮看下，或者rerun pls

zhwesky2010
zhwesky2010 reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注明下：这里由于paddle的Tensor.size表示的是元素个数，而不是形状，和其他框架有差异，所以API名：is_same_shape更合适些

python/paddle/incubate/sparse/multiary.py Outdated Show resolved Hide resolved
python/paddle/incubate/sparse/multiary.py Outdated Show resolved Hide resolved
@gsq7474741
Copy link
Contributor Author

已更新 @zhouwei25

zhwesky2010
zhwesky2010 previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010
Copy link
Contributor

@gsq7474741 需要rerun下失败的CI

dingjiaweiww
dingjiaweiww previously approved these changes Aug 22, 2022
View reviewed changes
@gsq7474741 gsq7474741 requested review from dingjiaweiww and zhwesky2010 and removed request for dingjiaweiww and zhwesky2010 August 22, 2022 09:09
@gsq7474741
Copy link
Contributor Author

@zhouwei25 已修改code style

dingjiaweiww
dingjiaweiww previously approved these changes Aug 23, 2022
View reviewed changes
zhwesky2010
zhwesky2010 reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ligoml
Copy link
Contributor

Ligoml commented Aug 26, 2022

请补充一下中文API文档哈

@gsq7474741
Copy link
Contributor Author

请补充一下中文API文档哈

目前sparse文档补充到哪个路径下呀

@OccupyMars2025 OccupyMars2025 mentioned this pull request Aug 28, 2022
Closed
@OccupyMars2025
Copy link
Contributor

我在学习这个任务，我把这个PR完全抄过去建立了新PR，同样出现 “conflicts”的问题，解决“conflicts”后出现了 9个CI失败，但似乎都与paddle.incubate.sparse.is_same_shape 稀疏 API无关

@gsq7474741
Copy link
Contributor Author

我在学习这个任务，我把这个PR完全抄过去建立了新PR，同样出现 “conflicts”的问题，解决“conflicts”后出现了 9个CI失败，但似乎都与paddle.incubate.sparse.is_same_shape 稀疏 API无关

没事 这个不是什么问题

@OccupyMars2025
Copy link
Contributor

image

飞桨黑客松2期时说是这个，不知道现在变了没有

@gsq7474741
Copy link
Contributor Author

image

飞桨黑客松2期时说是这个，不知道现在变了没有

现在不一样，内部还没建好sparse的目录和overview

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Aug 29, 2022 •
edited

image 飞桨黑客松2期时说是这个，不知道现在变了没有

现在不一样，内部还没建好sparse的目录和overview

你好，麻烦新增目录 https://github.com/PaddlePaddle/docs/tree/develop/docs/api/paddle/incubate/sparse
，并在其中增加is_same_shape_cn.rst

@gsq7474741
Copy link
Contributor Author

image 飞桨黑客松2期时说是这个，不知道现在变了没有

现在不一样，内部还没建好sparse的目录和overview

你好，麻烦新增目录 https://github.com/PaddlePaddle/docs/tree/develop/docs/api/paddle/incubate/sparse，并在其中增加is_same_shape_cn.rst

PaddlePaddle/docs#4705
在这个上面改行吗

@dingjiaweiww
Copy link
Contributor

@gsq7474741 Sparse API docs：PaddlePaddle/docs#5208

@gsq7474741
Copy link
Contributor Author

PaddlePaddle/docs#4705
已提交文档 @zhouwei25 @dingjiaweiww

@gsq7474741 gsq7474741 mentioned this pull request Sep 4, 2022
Merged
@zhwesky2010
Copy link
Contributor

@gsq7474741 麻烦修复一下CI问题，我觉得可以先合入了

@gsq7474741
Copy link
Contributor Author

@gsq7474741 麻烦修复一下CI问题，我觉得可以先合入了

已更新

@Ligoml
Copy link
Contributor

Ligoml commented Sep 8, 2022

英文API文档部分参考这个做一下修改吧，别的部分ok
PaddlePaddle/docs#4705 (comment)

Ligoml
Ligoml approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

jeff41404
jeff41404 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 417ce3c into PaddlePaddle:develop Sep 9, 2022
zhwesky2010
zhwesky2010 reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhwesky2010 pushed a commit to zhwesky2010/Paddle that referenced this pull request Oct 17, 2022
@gsq7474741 @zhwesky2010
【PaddlePaddle Hackathon 3 No.23】为 Paddle 新增 paddle.incubate.sparse.is…
69de807 
…_same_shape 稀疏 API (PaddlePaddle#45086)

* add paddle.incubate.sparse.is_same_shape

* add paddle.incubate.sparse.is_same_shape

* add paddle.incubate.sparse.is_same_shape

* add paddle.incubate.sparse.is_same_shape

* fix doc
@zhwesky2010 zhwesky2010 mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 left review comments

@jeff41404 jeff41404 jeff41404 approved these changes

@Ligoml Ligoml Ligoml approved these changes

@dingjiaweiww dingjiaweiww dingjiaweiww left review comments

Assignees

@luotao1 luotao1

@Ligoml Ligoml

@zhwesky2010 zhwesky2010

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gsq7474741 @zhwesky2010 @Ligoml @OccupyMars2025 @dingjiaweiww @jeff41404 @luotao1