[geometric]Add paddle.geometric.send_u_recv API #44580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
DesmonDay
changed the title
5 tasks
wawltor
reviewed
Aug 1, 2022
| @@ -58,6 +58,10 @@ class GraphSendRecvOpMaker : public framework::OpProtoAndCheckerMaker { | |||
| "The input tensor with data type float32, float64, int32, int64."); | |||
| AddInput("Src_index", "The source index tensor."); | |||
| AddInput("Dst_index", "The destination index tensor."); | |||
| AddInput("OutSizeTensor", | |||
There was a problem hiding this comment.
这里的命名为什么要强调是Tensor，看看是否命名是Out_size，和上面的变量命名一致
| @@ -58,6 +58,10 @@ class GraphSendRecvOpMaker : public framework::OpProtoAndCheckerMaker { | |||
| "The input tensor with data type float32, float64, int32, int64."); | |||
| AddInput("Src_index", "The source index tensor."); | |||
| AddInput("Dst_index", "The destination index tensor."); | |||
| AddInput("OutSizeTensor", | |||
| "(Tensor<int>, optional). The 0th dimension of the output." | |||
There was a problem hiding this comment.
Tensor, optional
为什么名字要加Tensor，是不是Out_size更好
There was a problem hiding this comment.
Tensor, optional的写法是参考其他类似的 OP，这里不改动；另外已经改成Out_size了。
| @@ -886,7 +886,7 @@ | |||
| backward : gelu_grad | |||
|
|
|||
| - api : graph_send_recv | |||
| args : (Tensor x, Tensor src_index, Tensor dst_index, str pool_type = "SUM", int64_t out_size = 0) | |||
There was a problem hiding this comment.
发现可以加默认值，不会报错，改好了。
| const auto& src_dims = x.dims(); | ||
| int64_t memset_size = 1; | ||
| if (out_size <= 0) { | ||
| for (int i = 0; i < src_dims.size(); ++i) { | ||
| memset_size *= src_dims[i]; | ||
| } | ||
| } else { | ||
| // set out dim following out_size. |
paddle/phi/infermeta/ternary.cc
Outdated
| } | ||
| out->set_dims(phi::make_ddim(dims_)); | ||
| } | ||
| out->set_dims(dims); |
paddle/phi/infermeta/ternary.cc
Outdated
| } else { | ||
| dst_count->set_dims({out_size}); | ||
| } | ||
| dst_count->set_dims({dims[0]}); |
wawltor
reviewed
Aug 1, 2022
| const auto& src_dims = x.dims(); | ||
| int64_t memset_size = 1; | ||
| if (out_size <= 0) { | ||
| for (int i = 0; i < src_dims.size(); ++i) { | ||
| memset_size *= src_dims[i]; | ||
| } | ||
| } else { | ||
| // set out dim following out_size. |
| @@ -0,0 +1,162 @@ | |||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
似乎不用每个文件都要放一个函数，看看能一类放在一个文件里面
There was a problem hiding this comment.
把文件名改成了 send_recv.py，用来放置既有 send 也有 recv 过程的函数；后续还会有 send.py，recv.py，用来存放其他类型的函数。
| [1, 4, 5]] | ||
|
|
||
| Args: | ||
| x (Tensor): The input tensor, and the available data type is float32, float64, int32, int64. |
| # TODO(daisiming): Should we add judgement for out_size: max(dst_index) + 1. | ||
|
|
||
| if _in_legacy_dygraph(): | ||
| out_size = convert_out_size_to_list(out_size) |
DesmonDay
force-pushed
the
change_graph_send_recv_outsize
branch
from
e7f16f9
to
f8fac9a
Compare
DesmonDay
commented
Aug 7, 2022
| pool_type.upper(), out_size) | ||
|
|
||
| check_variable_and_dtype(x, "X", ("float32", "float64", "int32", "int64"), | ||
| "send_u_recv") |
There was a problem hiding this comment.
这些地方得改成 graph_send_recv，因为 OP 的名字是这个。
DesmonDay
changed the title
DesmonDay
commented
Aug 8, 2022
| return _C_ops.final_state_graph_send_recv(x, src_index, dst_index, | ||
| pool_type.upper(), out_size) | ||
|
|
||
| check_variable_and_dtype(x, "X", ("float32", "float64", "int32", "int64"), |
There was a problem hiding this comment.
看起来float16也得加上。在下一个 PR 添加。
… change_graph_send_recv_outsize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
out_sizeattribute from int64_t to INTArray, supporting Tensor input and number input.Note