【PaddlePaddle Hackathon 3 No.5】为 Paddle 新增 bucketize #44195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add paddle.bucketize api
|
你的PR提交成功，感谢你对开源项目的贡献! |
Li-fAngyU
changed the title
jeff41404
reviewed
Jul 20, 2022
python/paddle/tensor/search.py
Outdated
| 'paddle.searchsorted') | ||
| if sorted_sequence.dim() != 1: | ||
| raise ValueError( | ||
| f"boundaries tensor must be 1 dimension, but got dim {sorted_sequence.dim()}" |
There was a problem hiding this comment.
it is better to understand if using sorted_sequence instead of boundaries tensor
jeff41404
reviewed
Jul 20, 2022
| paddle.disable_static(place) | ||
| sorted_sequence = paddle.to_tensor(self.sorted_sequence) | ||
| self.assertRaises(ValueError, paddle.bucketize, self.x, | ||
| sorted_sequence) |
There was a problem hiding this comment.
there is a test case "错误检查：未输入x和sorted_sequence时,能否正确抛出错误" in rfc, shall we add this test case?
|
Done |
|
需要补充中文文档至docs repo |
|
@sunzhongkai588 已补充 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
RFC的PR链接: PaddlePaddle/community#176
中文文档的PR链接: PaddlePaddle/docs#5089
为 Paddle 新增 bucketize API
paddle.bucketize 为 paddle.searchsorted 的sorted_sequence 在1维情况下的特例。比如输入数据 x = paddle.to_tensor([[0, 8, 4, 16], [-1, 2, 8, 4]])，sorted_sequence=paddle.to_tensor([2, 4, 8, 16])，则 paddle.bucketize(x, sorted_sequence) 或 x.bucketize(sorted_sequence) 得到 [[0, 2, 1, 3], [0, 0, 2, 1]]，paddle.bucketize(x, sorted_sequence, right=True) 或 x.bucketize(sorted_sequence, right=True) 得到 [[0, 3, 2, 4], [0, 1, 3, 2]] 。此API需支持的调用路径为：paddle.bucketize 和 Tensor.bucketize。