Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

Merged
merged 71 commits into from Jun 23, 2022
Merged

【Hackathon No.56 57 58 59】sparse elementwise add sub mul div #41857

merged 71 commits into from Jun 23, 2022

Conversation

gsq7474741
Copy link
Contributor

@gsq7474741 gsq7474741 commented Apr 15, 2022 •
edited by zhwesky2010

@gsq7474741 gsq7474741 mentioned this pull request Apr 15, 2022
Closed
@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Apr 15, 2022
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gsq7474741 gsq7474741 mentioned this pull request Apr 15, 2022
Closed
@gsq7474741 gsq7474741 changed the title [WIP] exit code 139 (interrupted by signal 11: SIGSEGV) when add sparse op 【Hackathon No.56 57 58 59】 Apr 16, 2022
@gsq7474741 gsq7474741 dismissed stale reviews from TCChenlong and zkh2016 via 2be0b15 June 15, 2022 10:08
@gsq7474741 gsq7474741 requested a review from zkh2016 June 16, 2022 08:12
@gsq7474741
Copy link
Contributor Author

你好，yaml形式规范可以参考下这个PR，合并到一起在设计上更好：https://github.com/PaddlePaddle/Paddle/pull/42935/files#diff-bfad6f19739eb95b60bd46fc6a77adbf3ccb4a5ebac465b7aba845ae15470f11

infoflow 2022-06-14 16-42-07

好的，已参考该设计修改

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Jun 17, 2022 •
edited

你好，经过内部讨论，目前形成以下一些sparse开发规范要求：

1.【yaml规则】：写到同一个yaml api，不要写多个
2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr
3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致

辛苦对kenrel注册名、与文件名进行修改

@gsq7474741
Copy link
Contributor Author

你好，经过内部讨论，目前达成以下一些sparse开发规范要求：

1.【yaml规则】：写到同一个yaml api，不要写多个，yaml需支持调度 2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr 3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致

辛苦对kenrel注册名、与文件名进行修改

加减乘除要写成四个文件么

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Jun 17, 2022 •
edited

你好，经过内部讨论，目前达成以下一些sparse开发规范要求：
1.【yaml规则】：写到同一个yaml api，不要写多个，yaml需支持调度 2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr 3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致
辛苦对kenrel注册名、与文件名进行修改

加减乘除要写成四个文件么

就写到sparse/elementwise_kernel.h/cc/cu吧，文件不用sparse前缀，使用目录区分

@gsq7474741
Copy link
Contributor Author

你好，经过内部讨论，目前达成以下一些sparse开发规范要求：

1.【yaml规则】：写到同一个yaml api，不要写多个，yaml需支持调度 2.【kernel名规则】：[计算名] + 异构后缀，matmul、matmul_csr_dense、softmax、softmax_csr 3.【文件名规则】：sparse/xx_kernel.cc，sparse/xx_kernel.cu，以目录区分，文件名与dense一致

辛苦对kenrel注册名、与文件名进行修改

加减乘除要写成四个文件么

这里复用比较多，就合到elementwise_kernel.h/cc/cu吧，不用sparse前缀

指的是dense的这个文件么

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Jun 17, 2022 •
edited

就写到sparse/elementwise_kernel.h/cc/cu里吧，文件不用sparse前缀，使用目录区分

zkh2016
zkh2016 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@zkh2016 zkh2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkh2016 zkh2016 merged commit e3d94fc into PaddlePaddle:develop Jun 23, 2022
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
@gsq7474741 @sneaxiy
【Hackathon No.56 57 58 59】sparse elementwise add sub mul div (PaddleP…
52447dc 
…addle#41857)
@gsq7474741 gsq7474741 mentioned this pull request Sep 4, 2022
Merged
@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Oct 24, 2022 •
edited

@gsq7474741 你好，这个kernel在FLAGS_use_system_allocator=0时单测是正确的，在FLAGS_use_system_allocator=1时会发生错误，kernel可能有地址访问bug需要修复。

586980951007279ae290208c1332e0f2

2fdac3d7babb941612da7827f697cdf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@chenwhql chenwhql chenwhql approved these changes

@zkh2016 zkh2016 zkh2016 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@lanxianghit lanxianghit lanxianghit left review comments

@DDDivano DDDivano Awaiting requested review from DDDivano

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gsq7474741 @TCChenlong @zhwesky2010 @DDDivano @chenwhql @zkh2016 @XiaoguangHu01 @lanxianghit