【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #40934

BrilliantYuKaimin · 2022-03-25T05:26:09Z

PR types

New features

PR changes

APIs

Describe

解决了issue：#40315
实现了paddle.heaviside。paddle.heaviside(x, y)在x>0时返回1，在x=0时返回y，在x<0时返回0。
设计文档：PaddlePaddle/community#57
中文文档：PaddlePaddle/docs#4641

paddle-bot-old · 2022-03-28T02:39:50Z

PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。
The format inspection passed. Your PR will be reviewed by experts of Paddle and developers from the open-source community. Stay tuned.

zoooo0820

目前尚有几个CI未能通过，需要check下CI未过的原因，整体看主要是单测超时的问题需要解决。

zoooo0820 · 2022-03-29T13:00:03Z

python/paddle/fluid/tests/unittests/test_elementwise_heaviside_op.py

@@ -0,0 +1,112 @@
+#   Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


单测中需要对照设计文档中补充测试case，目前仍然缺少不同dtype/设备/动态图、错误检查等测试内容。
此外，因为check_grad耗时比较多，可以适当减少OPTEST的用例。

已经补充了测试内容，OPTEST减少到了3个。

zoooo0820 · 2022-03-29T13:09:02Z

paddle/fluid/operators/elementwise/elementwise_heaviside_op.cc

+  }
+
+  void AddInputY() override {
+    AddInput("Y", "The tensor determining a Heaviside step function.");


这里对X,Y的说明还需要细化一下，可以参考https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/operators/elementwise/elementwise_floordiv_op.cc#L42

dingjiaweiww · 2022-03-31T03:38:54Z

请先通过CI噢~

zoooo0820

目前CI仍然有几个问题：

static-check: 代码格式问题，请参考CI提示的位置修改代码，或是再用pre-commit刷一下格式
coverage：单测仍然提示超时，可以尝试在保证单测覆盖率的情况下再适当减少一些OPTest的使用
Approval：请再确认一下对单测精度阈值的修改是否必要，如是则需要相关负责人的approve.

zoooo0820 · 2022-04-12T02:47:21Z

python/paddle/tensor/math.py

+    op_type = 'elementwise_heaviside'
+    axis = -1
+    act = None
+    if paddle.in_dynamic_mode():


这里由于最近的paddle内部的一些改动，辛苦将paddle.in_dynamic_mode()替换为_non_static_mode, 该方法在https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/tensor/math.py#L32

zoooo0820 · 2022-04-12T02:50:58Z

python/paddle/fluid/tests/unittests/test_elementwise_heaviside_op.py

+
+    def test_check_grad_ingore_y(self):
+        self.check_grad(
+            ['X'], 'Out', max_relative_error=0.005, no_grad_set=set('Y'))


这里如果使用默认设置max_relative_error会出现单测过不了的情况吗，修改默认对比精度需要专门的负责人Approve以通过CI

max_relative_error的默认值也是0.005，我已经在这里把这个参数删去。

zoooo0820

目前仍然需要处理下coverage和static两个ci的问题。
目前代码和线上分支出现了冲突，先merge下最新的develop分支解下冲突；另外static ci显示仍然存在一些代码风格问题。

BrilliantYuKaimin · 2022-04-13T14:18:13Z

目前仍然需要处理下coverage和static两个ci的问题。
目前代码和线上分支出现了冲突，先merge下最新的develop分支解下冲突；另外static ci显示仍然存在一些代码风格问题。

已经处理完成。

zoooo0820

CI问题已经解决，还有个别API使用规范问题需要解决一下

zoooo0820 · 2022-04-14T03:27:54Z

python/paddle/fluid/tests/unittests/test_elementwise_heaviside_op.py

+class TestHeavisideError(unittest.TestCase):
+    def test_input(self):
+        def test_input_x():
+            with paddle.fluid.dygraph.guard():


动态图下这个guard可以去掉，下同

如果报静态图的错可以先使用paddle.disable_static切换到动态图

zoooo0820 · 2022-04-14T03:30:55Z

python/paddle/fluid/tests/unittests/test_elementwise_heaviside_op.py

+from op_test import OpTest
+import paddle
+import paddle.fluid.core as core
+import paddle.fluid as fluid


目前fluid是目前正在逐步执行废弃计划的API，已有的也在逐步清理中。这里辛苦将这个单测文件中使用fluid相关的API统一替换为Paddle公开的API，避免增加后续清理工作。

静态图运行API请参考paddle.static目录下的API

设备检查API可以使用paddle.device.is_compiled_with_cuda()

BrilliantYuKaimin · 2022-04-14T14:44:35Z

现在既有paddle/phi/kernels/elementwise_kernel.cc又有paddle/phi/kernels/cpu/elementwise_kernel.cc，而paddle/phi/kernels/gpu/elementwise_kernel.cu已被删除，该如何安排elementwise_heaviside的位置？

BrilliantYuKaimin · 2022-04-16T02:44:25Z

由于出现了不好解决的复杂冲突，我重新提了一个 PR：#41872

paddle-bot-old · 2022-04-21T04:08:50Z

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

BrilliantYuKaimin added 10 commits March 25, 2022 12:10

增加heaviside的Python接口

299b726

增加heaviside算子的描述

bfde6ff

增加heaviside的相关函子

4c91cfa

增加heaviside及其梯度的实现

ea60774

增加heaviside及其梯度的核函数的注册

a439d57

增加heaviside的签名

d1322bc

增加heaviside单测

99a8433

Update elementwise_heaviside_op.cc

2106d2c

调整代码格式

53cdf22

Update elementwise_functor.h

1d07d18

dingjiaweiww added contributor External developers status: proposed labels Mar 28, 2022

dingjiaweiww assigned zoooo0820 and DDDivano Mar 28, 2022

dingjiaweiww added status: open review and removed status: proposed labels Mar 28, 2022

dingjiaweiww mentioned this pull request Mar 28, 2022

【PaddlePaddle Hackathon 第二期】任务总览 #40234

Closed

调整代码格式

36448fe

BrilliantYuKaimin force-pushed the heaviside_2 branch from 927ee1b to 36448fe Compare March 28, 2022 13:08

zoooo0820 reviewed Mar 29, 2022

View reviewed changes

BrilliantYuKaimin added 4 commits March 30, 2022 15:25

完善对输入的描述

ea9ba8d

Update test_elementwise_heaviside_op.py

5397eb8

Merge branch 'develop' into heaviside_2

0cf7567

Update test_elementwise_heaviside_op.py

0ecc4fc

TCChenlong added the PaddlePaddle Hackathon label Mar 31, 2022

paddle-bot-old bot removed the status: open review label Mar 31, 2022

add elementwise_heaviside

a3b84e1

BrilliantYuKaimin added 4 commits April 1, 2022 13:25

Update test_elementwise_heaviside_op.py

b97fcb9

Merge branch 'PaddlePaddle:develop' into heaviside_2

0739b3d

Update elementwise_sig.cc

e3f0831

add elementwise_heaviside

570f4c4

zoooo0820 reviewed Apr 12, 2022

View reviewed changes

BrilliantYuKaimin added 2 commits April 12, 2022 12:22

Update test_elementwise_heaviside_op.py

d7609ee

Update math.py

9ca329e

zoooo0820 reviewed Apr 13, 2022

View reviewed changes

BrilliantYuKaimin added 2 commits April 13, 2022 14:53

Update test_elementwise_heaviside_op.py

5bc256d

Merge branch 'develop' into heaviside_2

07d5607

BrilliantYuKaimin mentioned this pull request Apr 13, 2022

【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API PaddlePaddle/docs#4641

Merged

zoooo0820 reviewed Apr 14, 2022

View reviewed changes

Update test_elementwise_heaviside_op.py

30cf8c6

BrilliantYuKaimin force-pushed the heaviside_2 branch from a572b5f to 30cf8c6 Compare April 14, 2022 11:27

BrilliantYuKaimin closed this Apr 21, 2022

paddle-bot-old bot added the status: not progressed label Apr 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #40934

【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #40934

BrilliantYuKaimin commented Mar 25, 2022 •

edited

paddle-bot-old bot commented Mar 28, 2022

zoooo0820 left a comment

zoooo0820 Mar 29, 2022

BrilliantYuKaimin Mar 30, 2022

zoooo0820 Mar 29, 2022

BrilliantYuKaimin Mar 30, 2022

dingjiaweiww commented Mar 31, 2022

zoooo0820 left a comment

zoooo0820 Apr 12, 2022

BrilliantYuKaimin Apr 12, 2022

zoooo0820 Apr 12, 2022

BrilliantYuKaimin Apr 12, 2022

zoooo0820 left a comment

BrilliantYuKaimin commented Apr 13, 2022

zoooo0820 left a comment

zoooo0820 Apr 14, 2022

BrilliantYuKaimin Apr 14, 2022

zoooo0820 Apr 14, 2022

BrilliantYuKaimin Apr 14, 2022

BrilliantYuKaimin commented Apr 14, 2022 •

edited

BrilliantYuKaimin commented Apr 16, 2022

paddle-bot-old bot commented Apr 21, 2022

		@@ -0,0 +1,112 @@
		# Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #40934

【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #40934

Conversation

BrilliantYuKaimin commented Mar 25, 2022 • edited

PR types

PR changes

Describe

paddle-bot-old bot commented Mar 28, 2022

zoooo0820 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dingjiaweiww commented Mar 31, 2022

zoooo0820 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zoooo0820 left a comment

Choose a reason for hiding this comment

BrilliantYuKaimin commented Apr 13, 2022

zoooo0820 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrilliantYuKaimin commented Apr 14, 2022 • edited

BrilliantYuKaimin commented Apr 16, 2022

paddle-bot-old bot commented Apr 21, 2022

BrilliantYuKaimin commented Mar 25, 2022 •

edited

BrilliantYuKaimin commented Apr 14, 2022 •

edited