【PaddlePaddle Hackathon 2】29、为 Paddle 新增 PixelUnshuffle 组网 API #40728

BrilliantYuKaimin · 2022-03-19T08:29:34Z

PR types

New features

PR changes

APIs

Describe

完成了Issue：#40304
实现了paddle.nn.PixelUnshuffle和paddle.nn.functional.pixel_unshuffle，其行为是将形为[N,C,H,W]重塑成[N,C,H/r,r,W/r,r]的形状，再转置成[N,C,r,r,H/r,W/r]的形状，最后重塑成[N,Crr,H/r,W/r]的形状。
设计文档：PaddlePaddle/community#60
中文文档：PaddlePaddle/docs#4523

paddle-bot-old · 2022-03-19T08:29:39Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

CLAassistant · 2022-03-19T08:29:39Z

All committers have signed the CLA.

增加对extra_repr的测试

修正对extra_repr的测试

paddle-bot-old · 2022-03-22T02:54:41Z

PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。
The format inspection passed. Your PR will be reviewed by experts of Paddle and developers from the open-source community. Stay tuned.

BrilliantYuKaimin · 2022-04-14T07:32:57Z

unary.h中有一行的格式需要调整，删除不必要的空格：

完成

chenwhql · 2022-04-19T08:36:05Z

paddle/fluid/operators/pixel_unshuffle_op.cc

@@ -0,0 +1,130 @@
+/*Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


license格式有点问题，参考下其他头文件，增加下缩进和换行

chenwhql · 2022-04-19T08:39:56Z

paddle/fluid/operators/pixel_unshuffle_op.cc

+ public:
+  using framework::OperatorWithKernel::OperatorWithKernel;
+
+  void InferShape(framework::InferShapeContext* ctx) const override {


这个建议放到infermeta/backward.h中哈，其他的还有是因为正在迁移中，历史算子量比较大，我们还在推进中，比如可以参考softmax_op.cc

chenwhql · 2022-04-19T08:45:12Z

paddle/phi/kernels/pixel_unshuffle_grad_kernel.cc

@@ -0,0 +1,74 @@
+// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


这个文件需要放到kernels/impl目录中哈，命名可以参考impl目录中的文件，然后kernel.cc和kernel.cu分别在cpu和gpu下，kernels根目录下的cc中是设备无关的kernel实现，即这个kernel的实现里，不能有设备相关的函数，而这个kernel里的Transpose是仅支持CPU和GPU的，我们还有XPU以及将来可能有其他设备

chenwhql · 2022-04-19T08:45:30Z

paddle/phi/kernels/pixel_unshuffle_grad_kernel.h

+namespace phi {
+
+template <typename T, typename Context>
+void PixelUnshuffleGradKernel(const Context& ctx,


参数名建议统一为dev_ctx

chenwhql · 2022-04-19T08:46:11Z

paddle/phi/kernels/pixel_unshuffle_kernel.cc

@@ -0,0 +1,73 @@
+// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


同上，该Kernel属于仅支持CPU和GPU的实现，并非设备无关的实现，麻烦移到impl中

chenwhql · 2022-04-19T08:47:13Z

paddle/phi/ops/compat/pixel_unshuffle_sig.cc

+
+namespace phi {
+
+KernelSignature PixelUnshuffleOpArgumentMapping(


前向的ArgumentMapping实现和注册建议移除，会自动解析OpMaker的参数生成的

BrilliantYuKaimin · 2022-04-21T08:03:05Z

~~研发老师可以帮忙看一下 PR-CI-Kunlun-KP-Build 不通过的原因吗？~~

XiaoguangHu01

LGTM

shiyutang · 2022-04-25T06:05:02Z

@BrilliantYuKaimin 需要拉取下最新分支解决下冲突，解决后就可以准备合入了～

BrilliantYuKaimin · 2022-04-25T13:46:37Z

@BrilliantYuKaimin 需要拉取下最新分支解决下冲突，解决后就可以准备合入了～

完成

XiaoguangHu01

LGTM

TCChenlong

LGTM for API docs

BrilliantYuKaimin added 7 commits March 19, 2022 15:47

增加PixelUnshuffle的形状推断

995bdad

增加PixelUnshuffle的算子注册

8c401fb

增加PixelUnshuffle及其梯度的核函数

7a62b6e

增加PixelUnshuffle算子的描述

9591a48

增加PixelUnshuffle算子的签名

f6ad365

在Python层面增加PixelUnshuffle

73aed02

增加PixelUnshuffle的单测

8a259c0

paddle-bot-old bot added contributor External developers status: proposed labels Mar 19, 2022

Update test_pixel_unshuffle.py

b28157e

BrilliantYuKaimin force-pushed the pixel_unshuffle branch from 983ae4b to b28157e Compare March 19, 2022 14:26

BrilliantYuKaimin added 4 commits March 20, 2022 11:58

test=document_fix

d16b545

Update test_pixel_unshuffle.py

89e36a0

增加对extra_repr的测试

修正代码格式

3792573

Update test_pixel_unshuffle.py

3388c97

修正对extra_repr的测试

dingjiaweiww assigned zhiboniu and DDDivano Mar 22, 2022

dingjiaweiww added status: open review and removed status: proposed labels Mar 22, 2022

yang131313 unassigned DDDivano and zhiboniu Mar 22, 2022

yang131313 added status: proposed and removed status: open review labels Mar 22, 2022

BrilliantYuKaimin mentioned this pull request Mar 22, 2022

【PaddlePaddle Hackathon 第二期】任务总览 #40234

Closed

BrilliantYuKaimin added 2 commits March 22, 2022 21:05

修改pixel_unshuffle核函数的实现位置

9e28fef

修正代码格式

ef6f8ea

Merge branch 'PaddlePaddle:develop' into pixel_unshuffle

b13f476

michaelowenliu previously approved these changes Apr 15, 2022

View reviewed changes

BrilliantYuKaimin added 2 commits April 18, 2022 14:32

Merge branch 'PaddlePaddle:develop' into pixel_unshuffle

9aeb8b8

Update pixel_unshuffle_sig.cc

c3fbce6

BrilliantYuKaimin dismissed michaelowenliu’s stale review via c3fbce6 April 18, 2022 06:34

chenwhql reviewed Apr 19, 2022

View reviewed changes

XiaoguangHu01 mentioned this pull request Apr 20, 2022

【PaddlePaddle Hackathon 2】24、为 Paddle 新增 nn.ChannelShuffle 组网 API #40743

Merged

BrilliantYuKaimin added 8 commits April 21, 2022 08:04

Merge branch 'PaddlePaddle:develop' into pixel_unshuffle

d0e0351

Update vision.py

2310fc8

Update vision.py

777c9f8

add PixelUnshuffleGradInferMeta

b937d0e

remove PixelUnshuffleOpArgumentMapping

73fabcb

Update pixel_unshuffle_op.cc

d5f6874

调整pixel_unshuffle及其梯度的核函数的实现位置

e871227

Update pixel_unshuffle_op.cc

948f32b

chenwhql previously approved these changes Apr 24, 2022

View reviewed changes

XiaoguangHu01 previously approved these changes Apr 24, 2022

View reviewed changes

shiyutang requested a review from dingjiaweiww April 24, 2022 07:37

dingjiaweiww previously approved these changes Apr 24, 2022

View reviewed changes

Merge branch 'develop' into pixel_unshuffle

e270ab7

BrilliantYuKaimin dismissed stale reviews from dingjiaweiww, XiaoguangHu01, and chenwhql via e270ab7 April 25, 2022 10:51

XiaoguangHu01 approved these changes Apr 26, 2022

View reviewed changes

TCChenlong approved these changes Apr 26, 2022

View reviewed changes

jeff41404 merged commit 5be9b82 into PaddlePaddle:develop Apr 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【PaddlePaddle Hackathon 2】29、为 Paddle 新增 PixelUnshuffle 组网 API #40728

【PaddlePaddle Hackathon 2】29、为 Paddle 新增 PixelUnshuffle 组网 API #40728

BrilliantYuKaimin commented Mar 19, 2022 •

edited

paddle-bot-old bot commented Mar 19, 2022

CLAassistant commented Mar 19, 2022 •

edited

paddle-bot-old bot commented Mar 22, 2022

BrilliantYuKaimin commented Apr 14, 2022

chenwhql Apr 19, 2022

shiyutang Apr 20, 2022

BrilliantYuKaimin Apr 21, 2022

chenwhql Apr 19, 2022

BrilliantYuKaimin Apr 21, 2022

chenwhql Apr 19, 2022

BrilliantYuKaimin Apr 21, 2022

chenwhql Apr 19, 2022

BrilliantYuKaimin Apr 21, 2022

chenwhql Apr 19, 2022

BrilliantYuKaimin Apr 21, 2022

chenwhql Apr 19, 2022

BrilliantYuKaimin Apr 21, 2022

BrilliantYuKaimin commented Apr 21, 2022 •

edited

XiaoguangHu01 left a comment

shiyutang commented Apr 25, 2022

BrilliantYuKaimin commented Apr 25, 2022

XiaoguangHu01 left a comment

TCChenlong left a comment

		@@ -0,0 +1,130 @@
		/*Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,74 @@
		// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,73 @@
		// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


		namespace phi {

		KernelSignature PixelUnshuffleOpArgumentMapping(

【PaddlePaddle Hackathon 2】29、为 Paddle 新增 PixelUnshuffle 组网 API #40728

【PaddlePaddle Hackathon 2】29、为 Paddle 新增 PixelUnshuffle 组网 API #40728

Conversation

BrilliantYuKaimin commented Mar 19, 2022 • edited

PR types

PR changes

Describe

paddle-bot-old bot commented Mar 19, 2022

CLAassistant commented Mar 19, 2022 • edited

paddle-bot-old bot commented Mar 22, 2022

BrilliantYuKaimin commented Apr 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrilliantYuKaimin commented Apr 21, 2022 • edited

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

shiyutang commented Apr 25, 2022

BrilliantYuKaimin commented Apr 25, 2022

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

BrilliantYuKaimin commented Mar 19, 2022 •

edited

CLAassistant commented Mar 19, 2022 •

edited

BrilliantYuKaimin commented Apr 21, 2022 •

edited