Test improvement #13
Merged
Test improvement #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Feb 29, 2020
peter279k
force-pushed
the
test_improvement
branch
from
454986e
to
6dbf4dd
Compare
peter279k
commented
Feb 29, 2020
garak
requested changes
Feb 29, 2020
peter279k
force-pushed
the
test_improvement
branch
from
6dbf4dd
to
09dc7ab
Compare
peter279k
commented
Feb 29, 2020
|
Any news? |
peter279k
force-pushed
the
test_improvement
branch
from
09dc7ab
to
6c2cbea
Compare
garak
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
php-7.4snapshotversion test, and using thephp-7.4version instead on Travis CI build.Assert::readAttributeis deprecated onPHPUnit 8.2+version, using theFactory::getAlphabetinstead.The reference is as available here.