Refactor login page to "pop" #255
Open
+133
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
force-pushed
the
update-login
branch
2 times, most recently
from
0e27a38
to
9a8faaf
Compare
lishaduck
force-pushed
the
update-login
branch
from
9a8faaf
to
4746fa2
Compare
|
This works! I've tested, and it looks like the only issue is #264. Which is a big issue, but unrelated to this PR. I think this can merge. It's definitely not a regression, and might improve the UX.1 Footnotes
|
lishaduck
force-pushed
the
update-login
branch
from
4746fa2
to
c330b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to the login page in order to improve the user experience. The login page now pops back to the previous page after successful authentication, instead of pushing a new page onto the stack. This change ensures a smoother navigation flow for the user.
Type of Change