Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): 在适配器为 K8S 的时候,提交作业页面增加输入框:镜像地址 #954

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

tongchong
Copy link
Contributor

配置:

# # 是否为K8S集群,默认为false,为true时将在提交作业页面增加镜像url输入框
# K8S: true  

若K8S设置为true,则在页面中展示:
1699336507561

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 3469a33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@scow/grpc-api Minor
@scow/portal-server Minor
@scow/portal-web Minor
@scow/docs Minor
@scow/protos Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/lib-scheduler-adapter Patch
@scow/audit-server Patch
@scow/mis-server Minor
@scow/mis-web Minor
@scow/auth Minor
@scow/gateway Minor
@scow/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://PKUHPC.github.io/SCOW/pr-preview/pr-954/
on branch gh-pages at 2023-11-20 01:28 UTC

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (622ab7b) 68.21% compared to head (3469a33) 68.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   68.21%   68.21%           
=======================================
  Files         134      134           
  Lines        4005     4005           
  Branches      539      539           
=======================================
  Hits         2732     2732           
  Misses       1172     1172           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libs/config/src/cluster.ts Outdated Show resolved Hide resolved
@tongchong tongchong marked this pull request as ready for review November 15, 2023 03:50
@@ -151,6 +151,7 @@ message SubmitJobRequest {
optional string memory = 15;
optional string comment = 16;
bool save_as_template = 17;
optional string extra_options = 18;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra_options需要留有扩展性,应该是map<string, string>用来存放更多的数据

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

适配器那边的接口,使用的是 repeated string extra_options = 15; 我将proto/portal/job.proto也与其统一,改为string[]

@ddadaal
Copy link
Member

ddadaal commented Nov 16, 2023

后续如果有必要,把extra_options改成map<string, string>的字段,同时修改SCOW API。

@tongchong
Copy link
Contributor Author

我把把extra_options改成map<string, string>的字段,因为需要记录到模板中。适配器那边暂时不动。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants