feat(mis): 增加允许改变作业时限的hook: allowChangeJobTimeLimit #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 29199d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tongchong
changed the title
ddadaal
reviewed
Apr 27, 2024
| const { cluster, limitMinutes, jobId } = request; | ||
| const { cluster, limitMinutes, jobId, operatorUserId } = request; | ||
|
|
||
| await callHook("allowChangeJobTimeLimit", { cluster, limitMinutes, jobId, operatorUserId }, logger); |
There was a problem hiding this comment.
这个调用时机应该是改变了作业时限changeJobTimeLimit，而不是允许改变吧？
There was a problem hiding this comment.
这个hook是让外界的服务来决定是否能够修改作业时限，所以要在调用适配器之前就调用。暂时想法是外界如果有hook服务，如果 该hook正常返回，就继续执行，如果外界服务不允许更改作业时限，那将返回错误，scow这边再抛出错误
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加改变作业时限的hook: allowChangeJobTimeLimit
功能：
当修改作业时限时，将cluster、limitMinutes、jobId、operatorUserId作为传参调用hook，可以由外部hook调用的服务来决定允许修改或者抛出错误。