Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): AI 新增再次提交作业功能 #1225

Merged
merged 66 commits into from May 16, 2024
Merged

Conversation

ZihanChen821
Copy link
Contributor

@ZihanChen821 ZihanChen821 commented Apr 25, 2024

改动

AI 平台 作业提交时保存 提交参数,用户可以在作业列表点击该作业的再次提交按钮 进入创建应用或者训练页面, 获取上次提交参数后回填表单数据,用户可依据需求自己修改参数再次提交

  1. 提交作业时保存参数

image

image

  1. 在正在运行作业或已完成作业中,作业操作新增 再次提交
    image

  2. 跳转至对应的创建应用和训练页面, 参数回填,供用户修改后再次提交新的作业
    image

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 8506020

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ZihanChen821 ZihanChen821 changed the title Feat ai re submit job feat(ai): AI 新增再次提交作业功能 Apr 25, 2024
@ZihanChen821 ZihanChen821 marked this pull request as ready for review May 13, 2024 06:36
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label May 13, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal May 13, 2024 06:36
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

描述里加一个gif或者截图演示一下功能

apps/ai/src/server/trpc/route/jobs/jobs.ts Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels May 13, 2024
@ZihanChen821 ZihanChen821 requested a review from ddadaal May 14, 2024 06:33
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels May 14, 2024
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels May 14, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ChangeRequested labels May 15, 2024
@ddadaal
Copy link
Member

ddadaal commented May 15, 2024

看你还没有request review,所以我先不合并,如果决定没有后续的修改的话可以直接合并

@ZihanChen821 ZihanChen821 merged commit 7bcf3bb into master May 16, 2024
9 checks passed
@ZihanChen821 ZihanChen821 deleted the feat-ai-re-submit-job branch May 16, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants