Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect reader used for CSV files with BOM #4028 #4029

Merged
merged 1 commit into from
May 16, 2024
Merged

Incorrect reader used for CSV files with BOM #4028 #4029

merged 1 commit into from
May 16, 2024

Conversation

SchmidtClaudia
Copy link
Contributor

This is:

  • a bugfix

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

#4028

@SchmidtClaudia SchmidtClaudia mentioned this pull request May 15, 2024
Closed
2 tasks
@SchmidtClaudia SchmidtClaudia force-pushed the issue4028 branch 3 times, most recently from 4ae1bbd to 6b4b988 Compare May 15, 2024 09:33
@oleibman oleibman added this pull request to the merge queue May 16, 2024
Merged via the queue into PHPOffice:master with commit 1314f82 May 16, 2024
13 checks passed
@oleibman
Copy link
Collaborator

Thank you for your contribution, and my apologies for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@oleibman oleibman oleibman left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SchmidtClaudia @oleibman @derrabus