Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Duplicate Titles When Reading Multiple HTML Files #1829

Merged
merged 1 commit into from Feb 27, 2021
Merged

Avoid Duplicate Titles When Reading Multiple HTML Files #1829

merged 1 commit into from Feb 27, 2021

Commits on Feb 8, 2021

  1. Avoid Duplicate Titles When Reading Multiple HTML Files

    This issue arose while researching issue #1823. The issue was not a bug;
    it just required clarification to the author of how to use the software.
    But, while researching, I discovered that loading html into 2
    sheets of a spreadsheet has a problem if the html title tag is the same
    for the 2 sheets. PhpSpreadsheet would be able to save the resulting file,
    but Excel would not be able to read it properly because of the duplicate title.
    The worksheet setTitle method allows for disambiguation is such a circumstance.
    The html reader passed a parameter indicating "don't disambiguate", but I can't
    see any harm in changing that to "disambiguate". An extremely simple fix,
    with tests to back it up.
    oleibman committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    0bbaf5a View commit details
    Browse the repository at this point in the history