Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading XSLS style alignments from XML #1710

Merged
merged 1 commit into from Jan 31, 2021

Commits on Nov 11, 2020

  1. Fixed reading XSLS style alignments from XML

    The attribute `$alignmentXml` given to the private method `readAlignmentStyle` is the alignment XML tag that contains the alignment data itself. But inside that method all data are read from another `alignment` XML tag within that given tag. This redundant child-node access resulted in the following error- / notice-message: `PHP Notice:  Trying to access array offset on value of type null in /foo/bar/baz/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Xlsx/Styles.php on line 146`
    
    These changes remove the redundant child-node access in the method `readAlignmentStyle`.
    addiks committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    5e696d4 View commit details
    Browse the repository at this point in the history