Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdf Writer strtoupper() fix #1629

Merged
merged 2 commits into from Feb 28, 2021
Merged

Pdf Writer strtoupper() fix #1629

merged 2 commits into from Feb 28, 2021

Commits on Aug 25, 2020

  1. _setPageSize's strtoupper() on array argument 

    PhpSpreadsheet/Writer/Pdf.php Class defines a protected static mixed array called $paperSizes, this array contains string values along with array values. 'strtoupper() expects parameter 1 to be string, array given' error happens due to array passed to $paperSize variable from that $paperSizes mixed array on the Mpdf Class where Pdf extends

Examples of cases, when a 'Letter' paper size is chosen, then no problem occurs since the index in that value for the array is a string value, but when 'Tabloid' paper size is chosen the value in the index for that paper size is an array, that's when the strtoupper() error happens
    @adancabanas
    adancabanas committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    d7ef5f6 View commit details
    Browse the repository at this point in the history

  2. _setPageSize's strtoupper() on array argument 

    PhpSpreadsheet/Writer/Pdf.php Class defines a protected static mixed array called $paperSizes, this array contains string values along with array values. 'strtoupper() expects parameter 1 to be string, array given' error happens due to array passed to $paperSize variable from that $paperSizes mixed array on the Dompdf Class where Pdf extends

Examples of cases; when a 'Letter' paper size is chosen, then no problem occurs since the index in the array for that value a string, but when 'Tabloid' paper size is chosen the value in the index for that paper size is an array, that's when the strtoupper() error happens.
    @adancabanas
    adancabanas committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    1affc1c View commit details
    Browse the repository at this point in the history