-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to send mails using AWS SES #2877
Add support to send mails using AWS SES #2877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to cover the new code with tests ?
Hi @jrfnl. I'm not sure how to test this without an AWS account and without AWS SDK libraries installed. Also, I don't know how to warn anyone who wants to use this feature that they must have AWS SDK v3 installed. |
While I can see that you've put a lot of effort in here (thank you for that), I'm not too keen on merging this. AWS SES is a proprietary thing, but it accepts a fully-formed RFC822 message, which you can get out of PHPMailer via |
Hi @Synchro. Using getSentMIMEMessage() was my first aproach, but it requieres some extra adjustments to use PHPMailer with this, and this way the "bcc" headers are ignored because "preSend" doesn't include them on MIME. Finally I had to made those changes to be more friendly to people who are already using PHPMailer. Now you're only to mark as "$mail->useSes()" and it works same way than all others. |
BCC addresses should never be in headers? Even then, you could easily insert an extra header via your own wrapper after fetching the built message. I still think there is too much going on in here for a single proprietary option and it would be better implemented in a subclass, where you would not even have to call Put it like this, if I was using SES, this is how I would implement it anyway. |
No description provided.