Tests: rename base class and make abstract #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BaseSniffTest` class, which is used as a basis for all test classes, should by rights be an `abstract` class as it doesn't contain any tests itself. However, using the `Test` suffix for abstract test case classes is deprecated since PHPUnit 9.6. Even though this wasn't causing us any problems so far (as the class wasn't `abstract`), let's tidy this up to future-proof PHPUnit cross-version compatibility. So, in this commit: * The `BaseSniffTest` class is renamed to `BaseSniffTestCase`, including updating the file name to match. * All test classes which `extend` the class have been updated to now extend the `BaseSniffTestCase`. Ref: sebastianbergmann/phpunit#5132
jrfnl
added
chores/QA
PR: quick merge
fredden
approved these changes
Jul 31, 2023
wimg
approved these changes
Aug 3, 2023
github-actions
bot
removed
PR: ready for review
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseSniffTestclass, which is used as a basis for all test classes, should by rights be anabstractclass as it doesn't contain any tests itself.However, using the
Testsuffix for abstract test case classes is deprecated since PHPUnit 9.6.Even though this wasn't causing us any problems so far (as the class wasn't
abstract), let's tidy this up to future-proof PHPUnit cross-version compatibility.So, in this commit:
BaseSniffTestclass is renamed toBaseSniffTestCase, including updating the file name to match.extendthe class have been updated to now extend theBaseSniffTestCase.Ref: sebastianbergmann/phpunit#5132