UtilityMethodTestCase: new parseFile() method
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
testutils/new-configdouble-utility-class
branch
4 times, most recently
from
a675d0d
to
c61fa32
Compare
jrfnl
force-pushed
the
testutils/new-parsefile-method
branch
from
70efda6
to
bb307c1
Compare
|
Rebased without changes. Setting to draft as this PR depends on #550, which has to be merged first. |
jrfnl
force-pushed
the
testutils/new-configdouble-utility-class
branch
from
c61fa32
to
4f0f9a4
Compare
Base automatically changed from
testutils/new-configdouble-utility-class
to
develop
May 20, 2024 17:55
This abstracts the parsing of a file out from the `setUpTestFile()` method, without changing the functionality. Having the parsing of a file as a separate method allows for tests to parse a secondary test case file for use in a test. As the new method doesn't create any functional changes, it is already covered by existing tests.
jrfnl
force-pushed
the
testutils/new-parsefile-method
branch
from
bb307c1
to
0efda76
Compare
|
Rebased without changes. Marking as ready as #550 has been merged now. Merging once the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstracts the parsing of a file out from the
setUpTestFile()method, without changing the functionality.Having the parsing of a file as a separate method allows for tests to parse a secondary test case file for use in a test.
As the new method doesn't create any functional changes, it is already covered by existing tests.