Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct error message when path not found #509

Merged
merged 1 commit into from Aug 25, 2023
Merged

Correct error message when path not found #509

merged 1 commit into from Aug 25, 2023

Conversation

fredden
Copy link
Member

@fredden fredden commented Aug 25, 2023

While reviewing #501, I noticed that the error message will inject false into the string, not the actual directory that couldn't be found. This pull request fixes that.

jrfnl
jrfnl approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, good catch! Luckily an error I've never seen IRL 😂 (and the code doesn't have tests as it is for the website generation, not part of the actual package)

@jrfnl jrfnl added this to the 1.0.x Next milestone Aug 25, 2023
@jrfnl
Copy link
Member

jrfnl commented Aug 25, 2023

Merging (the build failure is a known issue and unrelated to this PR).

@jrfnl jrfnl merged commit a731124 into PHPCSStandards:develop Aug 25, 2023
41 of 45 checks passed
@fredden fredden deleted the gh-pages-error-message branch August 25, 2023 11:52
@jrfnl
Copy link
Member

jrfnl commented Aug 25, 2023

Thanks @fredden !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Type: chores/QA
Projects
None yet
Milestone
1.0.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredden @jrfnl